switch non testing build to devel #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeferguson
force-pushed
the
test_released
branch
from
dc56c4a
to
3efb4c3
Compare
|
@ahcorde this is now failing for the right reasons (hpp file not present) - but I know it's not the cleanest approach - is there a better docker container we should be using? Or maybe we just manually define the ROS_DISTRO variable here in the config.yaml? (I've not really worked with GitHub CI recently...) EDIT: in theory, we can also remove a bunch of the apt configuration stuff in the build-rolling-testing job, since the docker is already using the ros2-testing debian repository |
ahcorde
approved these changes
Aug 20, 2024
|
Re-running CI now that rolling sync is out - I expect all tests to pass (and then I'll merge this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.