Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve stereo calibration tutorial #1065

Merged
merged 1 commit into from
Feb 7, 2025
Merged

improve stereo calibration tutorial #1065

merged 1 commit into from
Feb 7, 2025

Conversation

mikeferguson
Copy link
Member

  • make topic names consistent by removing the my_ prefix on some topics
  • show the output of ros2 service list so that service names are more clear
  • explain what left/right/left_camera/right_camera actually mean

* make topic names consistent by removing the `my_` prefix on some topics
* show the output of `ros2 service list` so that service names are more clear
* explain what left/right/left_camera/right_camera actually mean
@mikeferguson
Copy link
Member Author

Noticed a few things while answering #1064

@ahcorde ahcorde merged commit e00d008 into rolling Feb 7, 2025
4 checks passed
@ahcorde ahcorde deleted the camera_info_updates branch February 7, 2025 08:48
@ahcorde
Copy link
Contributor

ahcorde commented Feb 7, 2025

https://github.com/Mergifyio backport jazzy humble

Copy link
Contributor

mergify bot commented Feb 7, 2025

backport jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 7, 2025
* make topic names consistent by removing the `my_` prefix on some
topics
* show the output of `ros2 service list` so that service names are more
clear
* explain what left/right/left_camera/right_camera actually mean

(cherry picked from commit e00d008)
mergify bot pushed a commit that referenced this pull request Feb 7, 2025
* make topic names consistent by removing the `my_` prefix on some
topics
* show the output of `ros2 service list` so that service names are more
clear
* explain what left/right/left_camera/right_camera actually mean

(cherry picked from commit e00d008)

# Conflicts:
#	camera_calibration/doc/tutorial_stereo.rst
ahcorde pushed a commit that referenced this pull request Feb 7, 2025
* make topic names consistent by removing the `my_` prefix on some
topics
* show the output of `ros2 service list` so that service names are more
clear
* explain what left/right/left_camera/right_camera actually mean<hr>This
is an automatic backport of pull request #1065 done by
[Mergify](https://mergify.com).

Co-authored-by: Michael Ferguson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants