Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add downsample_rate param and use image header header time. #274 #947

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Open

add downsample_rate param and use image header header time. #274 #947

wants to merge 2 commits into from

Conversation

mishra39
Copy link

This PR aims to resolve issue #274 where sec_per_frame_ parameter is unintuitive.

  • [✔️ ] Add new parameter to extract every Nth frame.
  • [ ✔️ ] Replace time::now() with msg->header.time to compute time between frames

@mishra39 mishra39 changed the title add downsample_rate param and use image header header time. Resolves #274 add downsample_rate param and use image header header time. #274 Feb 21, 2024
@mikeferguson
Copy link
Member

I haven't really reviewed this yet - but it is going to conflict heavily with #944 (which is trying to remove this node entirely, will merging the functionality into image_saver)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ros2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mishra39 @mikeferguson @ahcorde