Run clean_rosdep_yaml.py on rosdep YAML files
#41118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that the the validation fails, it seems like there is some mismatch between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rosdep YAML files have diverged from the formatting enforced by
scripts/clean_rosdep_yaml.py. As a result, the script is not particularly useful since when someone runs it, it makes hundreds of lines of changes, as opposed to a targeted change on their contribution.Thus, this PR brings the YAML formatting up-to-date by running:
python3 scripts/clean_rosdep_yaml.py rosdep/python.yaml rosdep/python.yamlpython3 scripts/clean_rosdep_yaml.py rosdep/base.yaml rosdep/base.yamlpython3 scripts/clean_rosdep_yaml.py rosdep/osx-homebrew.yaml rosdep/osx-homebrew.yamlpython3 scripts/clean_rosdep_yaml.py rosdep/ruby.yaml rosdep/ruby.yamlgentoo.yamlbecause formatting only removed the comment at the top that specifies that the file should not be removed and is kept for legacy purposes.)For what it's worth, I ran that above script with
Python 3.11.3on Mac OSx 13.2.1.