Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust debug message that requested goal is already expired. #1363

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

adjust debug message that requested goal is already expired. #1363

wants to merge 1 commit into from

Conversation

fujitatomoya
Copy link
Collaborator

closes #1236

@fujitatomoya
Copy link
Collaborator Author

@Barry-Xu-2018 could you take a look? just a minor comment and debug message fixes only.

CC: @ahcorde @clalancette

@Barry-Xu-2018
Copy link
Contributor

LGTM. This additional information can help users realize that they set the result timeout too short.

@fujitatomoya
Copy link
Collaborator Author

yes that is the only intention here. maybe we should escalate the log level from debug to warn?

@Barry-Xu-2018
Copy link
Contributor

yes that is the only intention here. maybe we should escalate the log level from debug to warn?

Totally agree. WARN is better.

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/action-result-responce-could-timeout branch from e2f5038 to e5fe615 Compare September 29, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError in ActionServer._execute_goal
2 participants
@fujitatomoya @Barry-Xu-2018