[Service introspection] add writer_guid to rmw_client_t #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Chen <[email protected]>
This was referenced Jul 7, 2022
ivanpauno
reviewed
Jul 13, 2022
14 tasks
|
Closing in favor of #327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a prototype for the service introspection REP (ros-infrastructure/rep#360) implementing the proposed single serialized message approach (ros-infrastructure/rep#360 (comment)).
Currently there is no way to get the client's writer guid from the context of
rcl_send_requestwhich is needed by the proposed service introspection feature to populate the ServiceEventInfoclient_idfield such that an unique identifier for a service event may be built.Connects to ros2/ros2#1285