Fix the build with rmw_fastrtps_dynamic. #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building with *only* rmw_fastrtps_dynamic, there is no test named "test_play_services__rmw_fastrtps_cpp" to mark as xfail. Instead, it is called "test_play_services__rmw_fastrtps_dynamic_cpp", so make sure to add a different xfail marking for that test. Signed-off-by: Chris Lalancette <[email protected]>
clalancette
requested review from
MichaelOrlov and
jhdcs
and removed request for
a team
|
FYI: the Rpr job here is failing because All of that is to say is that I don't think that it should prevent this PR from going in. |
|
CI:
|
|
https://github.com/Mergifyio backport iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
When building with *only* rmw_fastrtps_dynamic, there is no test named "test_play_services__rmw_fastrtps_cpp" to mark as xfail. Instead, it is called "test_play_services__rmw_fastrtps_dynamic_cpp", so make sure to add a different xfail marking for that test. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit 744cdf0)
|
https://github.com/Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
When building with *only* rmw_fastrtps_dynamic, there is no test named "test_play_services__rmw_fastrtps_cpp" to mark as xfail. Instead, it is called "test_play_services__rmw_fastrtps_dynamic_cpp", so make sure to add a different xfail marking for that test. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit 744cdf0)
clalancette
added a commit
that referenced
this pull request
Aug 10, 2023
When building with *only* rmw_fastrtps_dynamic, there is no test named "test_play_services__rmw_fastrtps_cpp" to mark as xfail. Instead, it is called "test_play_services__rmw_fastrtps_dynamic_cpp", so make sure to add a different xfail marking for that test. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit 744cdf0) Co-authored-by: Chris Lalancette <[email protected]>
clalancette
added a commit
that referenced
this pull request
Aug 11, 2023
When building with *only* rmw_fastrtps_dynamic, there is no test named "test_play_services__rmw_fastrtps_cpp" to mark as xfail. Instead, it is called "test_play_services__rmw_fastrtps_dynamic_cpp", so make sure to add a different xfail marking for that test. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit 744cdf0) Co-authored-by: Chris Lalancette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with only rmw_fastrtps_dynamic, there is no test named "test_play_services__rmw_fastrtps_cpp" to mark as xfail. Instead, it is called
"test_play_services__rmw_fastrtps_dynamic_cpp", so make sure to add a different xfail marking for that test.
This should fix the failing build at https://build.ros2.org/view/Rci/job/Rci__nightly-fastrtps-dynamic_ubuntu_jammy_amd64/