[iron] Fix the build with rmw_fastrtps_dynamic. (backport #1416) #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
When building with *only* rmw_fastrtps_dynamic, there is no test named "test_play_services__rmw_fastrtps_cpp" to mark as xfail. Instead, it is called "test_play_services__rmw_fastrtps_dynamic_cpp", so make sure to add a different xfail marking for that test. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit 744cdf0)
mergify
bot
requested review from
MichaelOrlov and
james-rms
and removed request for
a team
|
CI:
|
|
New CI, pointing to the Iron branches:
|
|
I think use_fastrtps_dynamic was set to false, so keep an extra eye to the nightlies to see if this worked out as expected. @Crola1702 |
MichaelOrlov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1416 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com