[Humble] Add topics with zero message counts to the SQLiteStorage::get_metadata().

[MichaelOrlov]

• Closes Ros bag reindex failed to generate topic inside metadata.yaml if the message_count is 0 #1719
• Analog and manual backport of the Add topics with zero message counts to the SQLiteStorage::get_metadata(). #1725.
  Have to do manual backporting because the code base is very different on humble branch in the affected places.

[fujitatomoya]

@MichaelOrlov i am trying to address for rolling with #1725.

can i borrow your code for testing? i am not sure if this works for rolling... any suggestions?

[MichaelOrlov]

@fujitatomoya Sure, feel free to take any parts for rolling. The test should work for rolling as well; however, it will be better to parametrize it to run it for the mcap storage as well.

[MichaelOrlov]

@fujitatomoya I've updated get_metadata_include_topics_with_zero_messages test to run it for mcap as well.
Feel free to take it for rolling. It should fit for rolling as is now. I assume that no modification needed.

[fujitatomoya]

lgtm with green CI.

@MichaelOrlov thanks for the note. btw, this is also gonna go to iron after this humble fix, right? because #1725 only addressed rolling and jazzy.

[MichaelOrlov]

@fujitatomoya Thanks for the review. We can propagate either this PR to the Iron or #1725. Need to double-check the base sources on Iron to see which one is better fit.

[MichaelOrlov]

Pulls: #1722
Gist: https://gist.githubusercontent.com/MichaelOrlov/1a1a4f8ac0ad7670f8603b60e4eef957/raw/40ce70e63ea8ce5ccc15d405be9bd9194282d1d4/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_cpp rosbag2_storage_default_plugins rosbag2_tests
TEST args: --packages-above rosbag2_cpp rosbag2_storage_default_plugins rosbag2_tests
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14288

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[MichaelOrlov]

The RHEL9 build fails with error message

--- stderr: rosbag2_storage_default_plugins
14:30:34 �[K/home/jenkins-agent/workspace/ci_linux-rhel/ws/src/ros2/rosbag2/rosbag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_storage.c�[K In member functio�[Kvirtual rosbag2_storage::BagMetadata rosbag2_storage_plugins::SqliteStorage::get_metadat�[K’:
14:30:34 �[K/home/jenkins-agent/workspace/ci_linux-rhel/ws/src/ros2/rosbag2/rosbag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_storage.cpp:539:��[Kerro��[Kfind�[K’ is not a member o�[K�[K’; did you mea�[Kf�[K’?
14:30:34   539 |       auto it = std::�[Kfind�[K(
14:30:34       |                      �[K^~~~�[K
14:30:34       |                      �[Kf�[K

@clalancette Do you have any idea what RHEL complaining about?

[MichaelOrlov]

Re-run RHEL CI job after attempt to fix a build error.

• Linux-rhel

[MichaelOrlov]

@clalancette I've fixed the RHEL build. I would appreciate if you would approve this backporting PR additionally so I can merge it.

[clalancette]

@clalancette I've fixed the RHEL build. I would appreciate if you would approve this backporting PR additionally so I can merge it.

So unfortunately, that succeeding build on Humble is for RHEL-9, not RHEL-8 (which is what Humble supports). I think you should re-run the job on RHEL-8, and see what happens.

[MichaelOrlov]

Run CI for RHEL8

• Linux-rhel

[MichaelOrlov]

The warning message

Failed
rosbag2_py.flake8.E402 (./test/test_convert.py:30:1)

Failing for the past 1 build (Since [#1049](https://ci.ros2.org/job/ci_linux-rhel/1049/) )
Error Message
module level import not at top of file:
from rosbag2_py import (

is unrelated to the changes in this PR.
However, I've made a rebase and added suppression for those warning.

Re-run CI for RHEL8 after the rebase and suppressing PEP8:E402 warning

• Linux-rhel

[MichaelOrlov]

@clalancette Ok. Now the RHEL8 CI job is green. Ready to be approved.

[fujitatomoya]

either @clalancette or @MichaelOrlov can you create the backport PR by mergifyio? (i do not have permission on this repo)

[clalancette]

either @clalancette or @MichaelOrlov can you create the backport PR by mergifyio? (i do not have permission on this repo)

I'm not sure what you mean; this one was the backport PR, no?

[fujitatomoya]

@clalancette sorry for the complication,

• rolling, Add topics with zero message counts to the SQLiteStorage::get_metadata(). #1725
• jazzy, [jazzy] Add topics with zero message counts to the SQLiteStorage::get_metadata(). (backport #1725) #1731 (backport of rolling)
• iron, missing
• this PR is for humble

i have consulted with @MichaelOrlov before, because of the base code difference, we did take the different pathes to rolling/jazzy and humble/iron. so that plan was to develop humble with this one and backport to iron which is missing now.

[MichaelOrlov]

@Mergifyio backport iron

[mergify]

backport iron

✅ Backports have been created

• #1766 [Humble] Add topics with zero message counts to the SQLiteStorage::get_metadata(). (backport #1722) has been created for branch iron but encountered conflicts