Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Humble] Add topics with zero message counts to the SQLiteStorage::get_metadata(). #1722

Merged
merged 4 commits into from
Jul 26, 2024
Merged

[Humble] Add topics with zero message counts to the SQLiteStorage::get_metadata(). #1722

merged 4 commits into from
Jul 26, 2024

Commits on Jul 25, 2024

  1. Add topics with zero messages count to the SQLiteStorage::get_metadata() 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1121d92 View commit details
    Browse the repository at this point in the history

  2. Update get_metadata_include_topics_with_zero_messages test after rebase 

    - Parametrize get_metadata_include_topics_with_zero_messages test to run
for mcap and sqlite3 storage plugins.

Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1d9c759 View commit details
    Browse the repository at this point in the history

  3. Attempt to fix RHEL9 build failure 

    - Include <algorithm> header and explicitly use reference on
topic_metadata in a lambda capture list.

Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    6efa757 View commit details
    Browse the repository at this point in the history

  4. Suppress PEP8 warning about putting module level imports on top of file 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    3f88538 View commit details
    Browse the repository at this point in the history