Ignore non-standard outputs when searching for the witness commitment hash #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
8 tasks
marcos-iov
previously approved these changes
Jan 15, 2025
marcos-iov
force-pushed
the
feature/powpeg_validation_protocol-integration
branch
from
1fa8546 to
7aaee31
Compare
nathanieliov
force-pushed
the
coinbase-parsing-integration-rebased
branch
from
3c3164f to
f8e4a98
Compare
marcos-iov
force-pushed
the
feature/powpeg_validation_protocol-integration
branch
from
7aaee31 to
7231fa9
Compare
marcos-iov
force-pushed
the
coinbase-parsing-integration-rebased
branch
from
f8e4a98 to
3cb7478
Compare
marcos-iov
force-pushed
the
feature/powpeg_validation_protocol-integration
branch
from
7231fa9 to
d094673
Compare
marcos-iov
force-pushed
the
coinbase-parsing-integration-rebased
branch
from
3cb7478 to
06f5b15
Compare
Base automatically changed from
feature/powpeg_validation_protocol-integration
to
master
January 24, 2025 18:45
- Updated BridgeEventLoggerImpl constructor call - Fix failing tests - Update places using BitcoinUtils.findWitnessCommitment to use new method signature.
marcos-iov
force-pushed
the
coinbase-parsing-integration-rebased
branch
from
098659a to
6195ec9
Compare
|
marcos-iov
approved these changes
Jan 27, 2025
apancorb
approved these changes
Jan 27, 2025
julia-zack
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore non-standard outputs when searching for the witness commitment hash
## Motivation and Context
Coinbase transactions may sometimes contain non-standard outputs that cause the Bridge to fail parsing them. When iterating through the outputs of a coinbase transaction in search for the witness commitment hash, non-standard outputs should be ignored and continue searching through the remaining outputs.
How Has This Been Tested?
Unit tests
Types of changes
Checklist:
rskj:coinbase-parsing-integration-rebased