Ignore non-standard outputs when searching for the witness commitment hash #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
nathanieliov
force-pushed
the
coinbase-parsing-integration-rebased
branch
from
c66a50b to
37f8fba
Compare
marcos-iov
force-pushed
the
invalid-pegin-as-processed-integration-rebased
branch
from
b877d0a to
da9c490
Compare
nathanieliov
force-pushed
the
coinbase-parsing-integration-rebased
branch
from
37f8fba to
c6b323f
Compare
8 tasks
nathanieliov
force-pushed
the
invalid-pegin-as-processed-integration-rebased
branch
from
da9c490 to
34a2c25
Compare
nathanieliov
force-pushed
the
coinbase-parsing-integration-rebased
branch
from
c6b323f to
4a022ab
Compare
marcos-iov
force-pushed
the
invalid-pegin-as-processed-integration-rebased
branch
from
34a2c25 to
326de39
Compare
marcos-iov
force-pushed
the
coinbase-parsing-integration-rebased
branch
from
545c46b to
eeb4d41
Compare
marcos-iov
force-pushed
the
invalid-pegin-as-processed-integration-rebased
branch
from
326de39 to
7b48c64
Compare
Base automatically changed from
invalid-pegin-as-processed-integration-rebased
to
master
January 24, 2025 20:14
marcos-iov
force-pushed
the
coinbase-parsing-integration-rebased
branch
from
eeb4d41 to
5be57f3
Compare
marcos-iov
approved these changes
Jan 27, 2025
…460 activation - Add real cases testing malformed mainnet and testnet coinbase transaction - Get rid of use of BtcTransaction. findWitnessCommitment since this method was removed in the new bitcoinj thin version.
…d exceptions. - Use all activations instead of lovell
…om script bytes removing parsing operation from the logic - Add border test case
marcos-iov
force-pushed
the
coinbase-parsing-integration-rebased
branch
from
57b7a3b to
43a94d9
Compare
|
julia-zack
approved these changes
Jan 27, 2025
apancorb
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore non-standard outputs when searching for the witness commitment hash.
## Motivation and Context
Coinbase transactions may sometimes contain non-standard outputs that cause the Bridge to fail parsing them. When iterating through the outputs of a coinbase transaction in search for the witness commitment hash, non-standard outputs should be ignored and continue searching through the remaining outputs.
How Has This Been Tested?
Unit tests
Types of changes
Checklist:
fed:coinbase-parsing-integration-rebased