Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RTMediaAdmin.php to handle JSON decoding error #2067

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

the-hercules
Copy link
Contributor

#2054

Types of changes

What types of changes do your code introduce to the project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Details

  • How this issue fixed/resolved
    • In RTMediaAlbum.php , it was running json_decode 2 times on same string causes TypeError. Removing on json_decode fixes this issue.

Closing issues

Fixes: #2054

@the-hercules the-hercules self-assigned this Sep 9, 2024
@the-hercules the-hercules linked an issue Sep 9, 2024 that may be closed by this pull request
@the-hercules the-hercules merged commit 9d7991c into pre-release Sep 10, 2024
1 check passed
@pavanpatil1 pavanpatil1 added this to the v4.6.21 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import Json file not working
3 participants