CLDR v38 CI support #132
Merged
CLDR v38 CI support #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[This PR](unicode-org/cldr#474) added information about cases for pluralization of units. This code was not ready for that, and started returning whichever happened to be that last case in the section. For now, we'll just return the case-less version as we always did.
Previously, we were assuming that all unknown operands were `n`
We don't actually support "compact decimal" format numbers. To do so would require refactoring the way we compute the f, t, v, and w values. Since `c`/`e` are always 0 for non-"compact decimal" format numbers, we just hardcode it to 0 for now.
movermeyer
force-pushed
the
movermeyer/v38_support
branch
from
53127de
to
5217d7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fix the issues that prevent us from running CI with CLDR v38.
This PR replaces almost all of #68
What approach did you choose and why?
See #68 for all the context behind each of the changes.
What should reviewers focus on?
This doesn't actually mean that we can support v38. Indeed, there are still several known issues related to v38.
The impact of these changes
We'll be able to run CI against v38.