[WIP] Support the modern versions of CLDR #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movermeyer
force-pushed
the
mo.support_modern_cldr
branch
2 times, most recently
from
6adafcc
to
9bad5a6
Compare
movermeyer
force-pushed
the
mo.support_modern_cldr
branch
from
9bad5a6
to
d3d81cc
Compare
movermeyer
force-pushed
the
mo.support_modern_cldr
branch
from
d3d81cc
to
01433a3
Compare
movermeyer
force-pushed
the
mo.support_modern_cldr
branch
2 times, most recently
from
69d3f7f
to
cdad963
Compare
Previously, we were assuming that all unknown operands were `n`
We don't actually support "compact decimal" format numbers. To do so would require refactoring the way we compute the f, t, v, and w values. Since `c`/`e` are always 0 for non-"compact decimal" format numbers, we just hardcode it to 0 for now.
[This PR](unicode-org/cldr#474) added information about cases for pluralization of units. This code was not ready for that, and started returning whichever happened to be that last case in the section. For now, we'll just return the case-less version as we always did.
It was removed from the upstream in unicode-org/cldr#872
:ccp became official in unicode-org/cldr#104 :"fa-AF" was added in unicode-org/cldr#303
movermeyer
force-pushed
the
mo.support_modern_cldr
branch
from
cdad963
to
02a3114
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
There are a number of issues that prevent
ruby-cldrfrom being used with modern versions (especially v38+):c/eplural rule operands #63What approach did you choose and why?
I'm opening this PR as a base branch to merge all of the PRs for the individual fixes into.
Once all of the changes have been made, the CI will go ✅ on this PR and we can get it merged.
What should reviewers focus on?
Here is a list of the individual PRs that got merged into this one:
candeplural operands movermeyer/ruby-cldr#1numbers_testfor modern CLDR movermeyer/ruby-cldr#3You can review them independently to see all of the in-depth context.
The impact of these changes
Users of
ruby-cldrwill once again be able to use it with modern versions of CLDR.