Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Support the modern versions of CLDR #68

Closed
wants to merge 9 commits into from
Closed

[WIP] Support the modern versions of CLDR #68

wants to merge 9 commits into from

Commits on Feb 24, 2022

  1. Bump the default version of CLDR

    @movermeyer
    movermeyer committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    61ec68f View commit details
    Browse the repository at this point in the history

  2. Update numbers_test for modern CLDR

    @movermeyer
    movermeyer committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    fba1e5f View commit details
    Browse the repository at this point in the history

  3. Add pseudo-regions to territories test

    @movermeyer
    movermeyer committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    30118a5 View commit details
    Browse the repository at this point in the history

  4. Add the c and e plural operands 

    http://unicode.org/reports/tr35/tr35-numbers.html#Operands
    @movermeyer
    movermeyer committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    fa80ca5 View commit details
    Browse the repository at this point in the history

  5. Raise if we find an unknown operand 

    Previously, we were assuming that all unknown operands were `n`
    @movermeyer
    movermeyer committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    fec60e7 View commit details
    Browse the repository at this point in the history

  6. Add to_ruby support for c and e operands 

    We don't actually support "compact decimal" format numbers.
To do so would require refactoring the way we compute the f, t, v, and w values.

Since `c`/`e` are always 0 for non-"compact decimal" format numbers, we just hardcode it to 0 for now.
    @movermeyer
    movermeyer committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    25f93d2 View commit details
    Browse the repository at this point in the history

  7. Ignore plural cases of units for now 

    [This PR](unicode-org/cldr#474) added information about cases for pluralization of units.
This code was not ready for that, and started returning whichever happened to be that last case in the section.

For now, we'll just return the case-less version as we always did.
    @movermeyer
    movermeyer committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    3d009e8 View commit details
    Browse the repository at this point in the history

  8. Remove root language 

    It was removed from the upstream in unicode-org/cldr#872
    @movermeyer
    movermeyer committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    d97d312 View commit details
    Browse the repository at this point in the history

  9. Add new languages 

    :ccp became official in unicode-org/cldr#104
:"fa-AF" was added in unicode-org/cldr#303
    @movermeyer
    movermeyer committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    02a3114 View commit details
    Browse the repository at this point in the history