fix: remove unused config from gaoc

[ItsSudip]

What are the changes introduced in this PR?

We are removing 2 unused configs.

What is the related Linear task?

Resolves INT-3278

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new checks got introduced or modified in test suites. Please explain the changes.

N/A

---

Developer checklist

• My code follows the style guidelines of this project

• No breaking changes are being introduced.

• All related docs linked with the PR?

• All changes manually tested?

• Any documentation changes needed with this change?

• I have executed schemaGenerator tests and updated schema if needed

• Are sensitive fields marked as secret in definition config?

• My test cases and placeholders use only masked/sample values for sensitive fields

• Is the PR limited to 10 file changes & one task?

Reviewer checklist

• Is the type of change in the PR title appropriate as per the changes?

• Verified that there are no credentials or confidential data exposed with the changes.

Summary by CodeRabbit

• Chores
  • Streamlined the Google AdWords Offline Conversions configuration by removing the options for managing user data and personalization consent, resulting in a simplified setup and a cleaner interface for consent settings.

[coderabbitai]

Walkthrough

This pull request removes the consent-related configuration options from the Google AdWords Offline Conversions setup. In the backend configuration (db-config.json) and the JSON schema (schema.json), the keys or properties "personalizationConsent" and "userDataConsent" have been removed. Likewise, the UI configuration (ui-config.json) no longer presents single-select fields for these consents in the Event Settings section. The overall structure of the configuration files remains intact.

Changes

File(s)	Change Summary
src/.../google_adwords_offline_conversions/db-config.json src/.../google_adwords_offline_conversions/schema.json	Removed "personalizationConsent" and "userDataConsent" keys/properties from the default configuration and JSON schema.
src/.../google_adwords_offline_conversions/ui-config.json	Removed single-select fields for "userDataConsent" and "personalizationConsent" in the Event Settings section.
test/.../google_adwords_offline_conversions.json	Removed instances of "userDataConsent" and "personalizationConsent" fields from JSON objects; modified validation logic resulting in a successful outcome.

Possibly related PRs

• feat(garl): move GARL destination to new form builder #1715: Involved modifications to user consent fields in the Google AdWords remarketing lists schema, aligning closely with the changes in this PR.

Suggested reviewers

• lvrach
• am6010
• ssbeefeater
• debanjan97
• cisse21
• 1abhishekpandey
• sandeepdsvs
• krishna2020
• koladilip

Poem

I'm a little rabbit, hopping in the code,
Nibbling away at keys where old consents once strode.
Removing fields with a swift, joyful pace,
Clearing the path for a cleaner interface.
With a twitch of my nose and a skip in my beat,
I cheer for fresh changes that make our config complete!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b7162d0 and 754e8c0.

📒 Files selected for processing (1)

• test/data/validation/destinations/google_adwords_offline_conversions.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (java-kotlin)

🔇 Additional comments (2)

test/data/validation/destinations/google_adwords_offline_conversions.json (2)

1-430: Overall: Confirm Removal of Unused Consent Configuration Keys
The file no longer contains the previously defined "personalizationConsent" and "userDataConsent" keys across all configuration objects. This aligns perfectly with the PR objective of streamlining the configuration by removing unused settings. Please verify that no downstream consumers or tests rely on these keys.

---

88-88: Validation Outcome Updated
In the second configuration object, the "result" field is now set to true (as marked on line 88). This likely reflects that the configuration passes validation after the removal of the unused consent fields, and the previous error (related to consent keys) has been eliminated. Confirm that this updated validation result is consistent with the intended behavior.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fe22b4b) to head (63438e2).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop     #1902   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           53        53           
  Branches         7         7           
=========================================
  Hits            53        53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.