-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update plugins and integration sdk base url constants and unit test #1654
chore: update plugins and integration sdk base url constants and unit test #1654
Conversation
WalkthroughThe recent modifications transition the project from its beta phase to production. This involves updating the CDN paths used in tests and the URLs within the codebase, shifting from beta versions to their respective production counterparts. This marks a significant milestone, indicating readiness for wider use and reliability enhancements. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- packages/analytics-js/tests/components/configManager/cdnPaths.test.ts (1 hunks)
- packages/analytics-js/src/constants/urls.ts (1 hunks)
Additional comments: 2
packages/analytics-js/src/constants/urls.ts (1)
- 7-8: The updates to
DEST_SDK_BASE_URL
andPLUGINS_BASE_URL
correctly use template literals and constants for constructing the URLs, which enhances readability and maintainability. Good job on making these updates to move from beta to production URLs.packages/analytics-js/__tests__/components/configManager/cdnPaths.test.ts (1)
- 64-64: The update to use the
dummyVersion
variable in the test assertion is a good practice, enhancing the test's flexibility and maintainability. This change aligns well with the transition from beta to production URLs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1654 +/- ##
========================================
Coverage 53.89% 53.89%
========================================
Files 461 461
Lines 15588 15588
Branches 3098 3098
========================================
Hits 8401 8401
Misses 5881 5881
Partials 1306 1306 ☔ View full report in Codecov by Sentry. |
|
size-limit report 📦
|
PR Description
Linear task (optional)
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit