Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update plugins and integration sdk base url constants and unit test #1654

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Mar 21, 2024

PR Description

  • Default constant for plugins and integrations base url has been updated
  • beta path in the unit test has been updated

Linear task (optional)

  1. https://linear.app/rudderstack/issue/SDK-1419/update-plugins-and-integration-sdk-base-url-constants-in-the-code
  2. https://linear.app/rudderstack/issue/SDK-1422/remove-the-references-to-the-beta-version-in-the-unit-tests

Cross Browser Tests

Please confirm you have tested for the following browsers:

  • Chrome
  • Firefox
  • IE11

Sanity Suite

  • All sanity suite test cases pass locally

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Summary by CodeRabbit

  • Refactor
    • Updated analytics integration URLs from beta to production versions.
    • Improved test assertions for analytics integration CDN paths.

@MoumitaM MoumitaM requested a review from saikumarrs as a code owner March 21, 2024 04:17
Copy link
Contributor

coderabbitai bot commented Mar 21, 2024

Walkthrough

The recent modifications transition the project from its beta phase to production. This involves updating the CDN paths used in tests and the URLs within the codebase, shifting from beta versions to their respective production counterparts. This marks a significant milestone, indicating readiness for wider use and reliability enhancements.

Changes

File Path Change Summary
.../configManager/cdnPaths.test.ts Updated the CDN path assertion to use the dummyVersion variable, removing references to the beta version.
.../src/constants/urls.ts URLs updated from beta to production versions, eliminating beta references.

🐇✨
In the land of code and byte,
Where versions shift from beta light,
A rabbit hopped, with joy so bright,
For production paths now take flight.
No more beta, in the night,
Onward to production's height!
🚀🌕

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 14797b5 and 0299475.
Files selected for processing (2)
  • packages/analytics-js/tests/components/configManager/cdnPaths.test.ts (1 hunks)
  • packages/analytics-js/src/constants/urls.ts (1 hunks)
Additional comments: 2
packages/analytics-js/src/constants/urls.ts (1)
  • 7-8: The updates to DEST_SDK_BASE_URL and PLUGINS_BASE_URL correctly use template literals and constants for constructing the URLs, which enhances readability and maintainability. Good job on making these updates to move from beta to production URLs.
packages/analytics-js/__tests__/components/configManager/cdnPaths.test.ts (1)
  • 64-64: The update to use the dummyVersion variable in the test assertion is a good practice, enhancing the test's flexibility and maintainability. This change aligns well with the transition from beta to production URLs.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.89%. Comparing base (14797b5) to head (0299475).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1654   +/-   ##
========================================
  Coverage    53.89%   53.89%           
========================================
  Files          461      461           
  Lines        15588    15588           
  Branches      3098     3098           
========================================
  Hits          8401     8401           
  Misses        5881     5881           
  Partials      1306     1306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copy link

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Common Code - No bundling 15.81 KB 15.81 KB (0%) 16.5 KB
Remote Module Federation Mapping - CDN 330 B 330 B (0%) 512 B
Remote Module Federated Plugins - CDN 5.71 KB 5.71 KB (0%) 6 KB
Core ESM - NPM 7.64 KB 7.63 KB (-0.11% ▼) 8 KB
Core CJS - NPM 22.43 KB 22.44 KB (+0.04% ▲) 23 KB
Core - NPM 22.6 KB 22.55 KB (-0.2% ▼) 23 KB
Core Legacy - CDN 42.88 KB 42.88 KB (+0.02% ▲) 44 KB
Core - CDN 22.7 KB 22.69 KB (-0.04% ▼) 23 KB
Core (legacy build) - CDN - v1.1 31.54 KB 31.54 KB (0%) 32 KB
Core - NPM - v1.1 31.52 KB 31.52 KB (0%) 32 KB
Service Worker Module 22.64 KB 22.64 KB (0%) 24 KB
All Integrations (legacy build) - CDN 98.57 KB 98.57 KB (0%) 105 KB

@saikumarrs saikumarrs merged commit 177421c into develop Mar 21, 2024
10 checks passed
@saikumarrs saikumarrs deleted the feature/sdk-1419-update-plugins-and-integration-sdk-base-url-constants branch March 21, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants