Make tf flow functions usable for onnx #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vieting
requested review from
albertz,
curufinwe,
christophmluscher and
JackTemaki
|
This will be used e.g. in rwth-i6/i6_experiments#155. |
JackTemaki
reviewed
Jul 19, 2023
JackTemaki
force-pushed
the
peter_tf_onnx_flow
branch
from
33a9753
to
74b1abe
Compare
Closed
vieting
force-pushed
the
peter_tf_onnx_flow
branch
from
74b1abe
to
52e8dd1
Compare
|
The number of threads is now moved to the post config and the hashing issue for flow post configs (#436) is resolved. |
JackTemaki
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
(ONNX) Recognition with this worked fine, also from the code I see no issues. Potential TF changes should be covered by the AppTek-tests (@michelwi ?), so I guess this is all good.
No, we do not use this function. |
|
I tested the changes for one of my tf precomputed hybrid setups. |
michelwi
reviewed
Jul 28, 2023
christophmluscher
approved these changes
Jul 31, 2023
Atticus1806
pushed a commit
that referenced
this pull request
Oct 2, 2023
This was referenced Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To set up a recognition using RASR's
tensorflow-forwardflow node, we have helper functions inreturnn.flow.py. I'd like to generalize them to also support theonnx-forwardnode.This involves generalizing the existing function to create the precomputed feature flow and adding separate functions for tf and onnx with the specific needs for their configs. The function to integrate it into the base flow is basically just renamed and a version keeping the tf behavior is added.