Adds KenLM related jobs #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackTemaki
requested review from
albertz,
curufinwe,
christophmluscher,
Marvin84,
michelwi,
Judyxujj,
SimBe195,
vieting,
ZijYang and
Atticus1806
Adds a job for: - compiling KenLM - Building an ARPA-LM using lmplz - Converting an LM into binary format
JackTemaki
force-pushed
the
nick-kenlm-jobs
branch
from
45e4735
to
a5aca80
Compare
christophmluscher
requested changes
Sep 25, 2023
lm/kenlm.py
Outdated
|
|
||
| self.out_lm = self.output_path("lm.gz") | ||
|
|
||
| self.rqmt = {"cpu": 1, "mem": 4.0, "time": 1} |
There was a problem hiding this comment.
should this be configurable? text file size might vary?
There was a problem hiding this comment.
I mean you can always configure it later via job.rqmt, but yes I could add this as direct paramter.
There was a problem hiding this comment.
true.. my reasoning would be to put in the args of the job. otherwise, users will run once it crashes and then start thinking about it.. maybe not all users but my feeling/hope is that it would be less ^^
christophmluscher
approved these changes
Sep 25, 2023
Atticus1806
approved these changes
Sep 25, 2023
Atticus1806
pushed a commit
that referenced
this pull request
Oct 2, 2023
Adds a job for: - compiling KenLM - Building an ARPA-LM using lmplz - Converting an LM into binary format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a job for:
I had this stuff around for a longer time and completely forgot about it.