Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slurm, fix duplicate jobs #157

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

albertz
Copy link
Member

@albertz albertz commented Nov 23, 2023

Fix #156

@albertz
Copy link
Member Author

albertz commented Nov 27, 2023

Can someone review?

@michelwi
Copy link
Contributor

The behaviour looks correctly implemented to me.

Discussion question: should we add a flag to enable it? should it be on by default?

Also @albertz did you test this with the i6 cluster and does it solve your problem?

@albertz
Copy link
Member Author

albertz commented Nov 28, 2023

Yes I tested this, and I did not see the problem anymore (but maybe the cluster was just behaving fine since then).

In any case, I think if slurm responds with a valid job id, and also has return code 0, I don't see why we should ignore and throw away that job id. This looks like a bug to me.

@albertz albertz merged commit cbf529c into master Nov 28, 2023
3 checks passed
@albertz albertz deleted the albert-fix-slurm-duplicates-156 branch November 28, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More then one matching SLURM task
3 participants