Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified quaternion algebra documentation #37557

Merged
merged 4 commits into from
Mar 31, 2024
Merged

Modified quaternion algebra documentation #37557

merged 4 commits into from
Mar 31, 2024

Conversation

S17A05
Copy link
Member

@S17A05 S17A05 commented Mar 6, 2024

Updated details for John Voight's book "Quaternion Algebras" in the list of references and modified some docstrings in quaternion_algebra.py. Split off from #37173.

@S17A05
Modified quaternion algebra documentation
16535d3 
- Gave more details on the reference [Voi2021]
- Modified some docstrings
@S17A05 S17A05 mentioned this pull request Mar 6, 2024
Open
tscrim
tscrim requested changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some little things.

src/sage/algebras/quatalg/quaternion_algebra.py Outdated Show resolved Hide resolved
src/sage/algebras/quatalg/quaternion_algebra.py Outdated Show resolved Hide resolved
@S17A05
Implemented reviewer feedback
98abf2b 
Amend: Missed a period.
tscrim
tscrim approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@S17A05
Copy link
Member Author

S17A05 commented Mar 8, 2024 •
edited
Loading

I reset the review label since I noticed one more small thing that I wanted to change.

@S17A05 S17A05 requested a review from tscrim March 8, 2024 19:27
@tscrim
Copy link
Collaborator

tscrim commented Mar 10, 2024

LGTM.

@S17A05 S17A05 added this to the sage-10.3 milestone Mar 10, 2024
@S17A05
Copy link
Member Author

S17A05 commented Mar 10, 2024 •
edited
Loading

Since this cleans up the documentation of methods that are part of the Sage 10.3 milestone, I think it is important to get these changes into 10.3 as well. For this reason I have added the corresponding milestone - nonetheless, feel free to remove it if you disagree.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 3564537; changes) is ready! 🎉

@yyyyx4
Copy link
Member

yyyyx4 commented Mar 11, 2024

Since this cleans up the documentation of methods that are part of the Sage 10.3 milestone, I think it is important to get these changes into 10.3 as well. For this reason I have added the corresponding milestone - nonetheless, feel free to remove it if you disagree.

^ @vbraun

@tscrim
Copy link
Collaborator

tscrim commented Mar 11, 2024

I doubt this will make it into 10.3 as we are deep into the RC cycle and this is not a critical change.

@mkoeppe mkoeppe removed this from the sage-10.3 milestone Mar 20, 2024
@vbraun vbraun merged commit e087e70 into sagemath:develop Mar 31, 2024
13 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
@S17A05 S17A05 deleted the quat_doc branch April 1, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim Awaiting requested review from tscrim

Assignees
No one assigned
Labels
c: documentation p: trivial / 5
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
5 participants
@S17A05 @tscrim @yyyyx4 @vbraun @mkoeppe