extract _front_back_facets method out of _tikz_3d_in_3d polyhedron method #39597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jection of a polyhedron
seblabbe
force-pushed
the
tikz_3d_in_3d
branch
from
b22cdac to
8fec923
Compare
seblabbe
commented
Feb 27, 2025
|
Documentation preview for this PR (built with commit 82f898b; changes) is ready! 🎉 |
Removed unnecessary line
seblabbe
commented
Feb 27, 2025
Removed empty line at the end of file
fchapoton
reviewed
Feb 27, 2025
fchapoton
reviewed
Feb 27, 2025
|
autrement, c'est ok |
seblabbe
commented
Feb 28, 2025
seblabbe
commented
Feb 28, 2025
|
Thanks for the review. I made the changes. |
fchapoton
approved these changes
Feb 28, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 1, 2025
…n_3d polyhedron method
The code of the method `_tikz_3d_in_3d` is long. Also, the front and
back facets it computes for the projection of a polyhedron is
interesting by itself. Personally, I need this information in order to
define a polyhedron exchange transformation out of the projection of a
zonotope.
In this PR, we extract a `_front_back_facets` method out of the
`_tikz_3d_in_3d` method in the class Projection of a polyhedron.
Meanwhile, we also improve the SageMath/Python code. For instance:
```diff
- for index_facet in range(len(facets)):
- A = facets[index_facet].vector()[1:]
+ for index_facet,f in enumerate(facet_ineqs):
+ A = f.A()
```
This was done during Sage Days 128 with Jean-Philippe Labbé.
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
URL: sagemath#39597
Reported by: Sébastien Labbé
Reviewer(s): Frédéric Chapoton, Sébastien Labbé
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 1, 2025
…n_3d polyhedron method
The code of the method `_tikz_3d_in_3d` is long. Also, the front and
back facets it computes for the projection of a polyhedron is
interesting by itself. Personally, I need this information in order to
define a polyhedron exchange transformation out of the projection of a
zonotope.
In this PR, we extract a `_front_back_facets` method out of the
`_tikz_3d_in_3d` method in the class Projection of a polyhedron.
Meanwhile, we also improve the SageMath/Python code. For instance:
```diff
- for index_facet in range(len(facets)):
- A = facets[index_facet].vector()[1:]
+ for index_facet,f in enumerate(facet_ineqs):
+ A = f.A()
```
This was done during Sage Days 128 with Jean-Philippe Labbé.
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
URL: sagemath#39597
Reported by: Sébastien Labbé
Reviewer(s): Frédéric Chapoton, Sébastien Labbé
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 2, 2025
…n_3d polyhedron method
The code of the method `_tikz_3d_in_3d` is long. Also, the front and
back facets it computes for the projection of a polyhedron is
interesting by itself. Personally, I need this information in order to
define a polyhedron exchange transformation out of the projection of a
zonotope.
In this PR, we extract a `_front_back_facets` method out of the
`_tikz_3d_in_3d` method in the class Projection of a polyhedron.
Meanwhile, we also improve the SageMath/Python code. For instance:
```diff
- for index_facet in range(len(facets)):
- A = facets[index_facet].vector()[1:]
+ for index_facet,f in enumerate(facet_ineqs):
+ A = f.A()
```
This was done during Sage Days 128 with Jean-Philippe Labbé.
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
URL: sagemath#39597
Reported by: Sébastien Labbé
Reviewer(s): Frédéric Chapoton, Sébastien Labbé
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 3, 2025
…n_3d polyhedron method
The code of the method `_tikz_3d_in_3d` is long. Also, the front and
back facets it computes for the projection of a polyhedron is
interesting by itself. Personally, I need this information in order to
define a polyhedron exchange transformation out of the projection of a
zonotope.
In this PR, we extract a `_front_back_facets` method out of the
`_tikz_3d_in_3d` method in the class Projection of a polyhedron.
Meanwhile, we also improve the SageMath/Python code. For instance:
```diff
- for index_facet in range(len(facets)):
- A = facets[index_facet].vector()[1:]
+ for index_facet,f in enumerate(facet_ineqs):
+ A = f.A()
```
This was done during Sage Days 128 with Jean-Philippe Labbé.
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
URL: sagemath#39597
Reported by: Sébastien Labbé
Reviewer(s): Frédéric Chapoton, Sébastien Labbé
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code of the method
_tikz_3d_in_3dis long. Also, the front and back facets it computes for the projection of a polyhedron is interesting by itself. Personally, I need this information in order to define a polyhedron exchange transformation out of the projection of a zonotope.In this PR, we extract a
_front_back_facetsmethod out of the_tikz_3d_in_3dmethod in the class Projection of a polyhedron.Meanwhile, we also improve the SageMath/Python code. For instance:
This was done during Sage Days 128 with Jean-Philippe Labbé.
📝 Checklist