🎁 Upgrade Redis initializer to Hyrax 5's gen version #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, when looking at the `Hyrax::RedisEventStore.instance` we saw it's connection information as: `#<Redis client v4.8.1 for redis://localhost:6379/0>` We were expecting the connection to be the following: `#<Redis client v4.8.1 for redis://redis:6379/0>` What we were seeing in tests is when we hit the redis connection we were getting an error about not being able to connect to 127.0.0.1:6379 (e.g. localhost). With this commit, we have a clear connection to Redis. See Redis Config initializer: - https://github.com/samvera/hyrax/blob/966951ffaa72524e4a775f8a198bd51a47ece7d9/lib/generators/hyrax/templates/config/initializers/redis_config.rb#L1-L10 Co-authored-by: Kirk Wang <[email protected]>
kirkkwang
approved these changes
Dec 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, when looking at the
Hyrax::RedisEventStore.instancewe saw it's connection information as:#<Redis client v4.8.1 for redis://localhost:6379/0>We were expecting the connection to be the following:
#<Redis client v4.8.1 for redis://redis:6379/0>What we were seeing in tests is when we hit the redis connection we were
getting an error about not being able to connect to 127.0.0.1:6379 (e.g.
localhost).
With this commit, we have a clear connection to Redis.
See Redis Config initializer:
Co-authored-by: Kirk Wang [email protected]