Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎁 Upgrade Redis initializer to Hyrax 5's gen version #2093

Merged
merged 1 commit into from
Dec 20, 2023
Merged

🎁 Upgrade Redis initializer to Hyrax 5's gen version #2093

merged 1 commit into from
Dec 20, 2023

Commits on Dec 20, 2023

  1. 🎁 Upgrade Redis initializer to Hyrax 5's gen version 

    Prior to this commit, when looking at the
`Hyrax::RedisEventStore.instance` we saw it's connection information as:

`#<Redis client v4.8.1 for redis://localhost:6379/0>`

We were expecting the connection to be the following:

`#<Redis client v4.8.1 for redis://redis:6379/0>`

What we were seeing in tests is when we hit the redis connection we were
getting an error about not being able to connect to 127.0.0.1:6379 (e.g.
localhost).

With this commit, we have a clear connection to Redis.

See Redis Config initializer:

- https://github.com/samvera/hyrax/blob/966951ffaa72524e4a775f8a198bd51a47ece7d9/lib/generators/hyrax/templates/config/initializers/redis_config.rb#L1-L10

Co-authored-by: Kirk Wang <[email protected]>
    @jeremyf @kirkkwang
    jeremyf and kirkkwang committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    047c8bc View commit details
    Browse the repository at this point in the history