Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☄️ Valkyrize Hyku EPIC #2129

Merged
merged 594 commits into from
Apr 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
594 commits
Select commit Hold shift + click to select a range
28e31ae
Delete _repository_content.html.erb
ShanaLMoore Jan 26, 2024
963fda8
use hyrax-4-valkyrie-support bulkrax branch
ShanaLMoore Jan 26, 2024
db7e39d
🐛 App was not loading after updating Hyrax
kirkkwang Jan 29, 2024
44aa7f7
⚙️ Don't remove backtrace in dev
kirkkwang Jan 29, 2024
887fbf2
remove bulkrax_identifier from Hyku
ShanaLMoore Jan 29, 2024
4322d9c
🧹 Make the appropriate link generate
kirkkwang Jan 30, 2024
c7ac8d6
🧹 Add Valkyrie test adapter
jeremyf Jan 30, 2024
89d0c59
🧹 Always with the coppers
jeremyf Jan 30, 2024
9be2b81
Merge pull request #2158 from samvera/i903-move-find-by-bulkrax-ident…
jeremyf Jan 30, 2024
e05e5c1
Updating Hyrax to latest version
jeremyf Jan 30, 2024
fc72267
🧹 Rework logic for #hydra_model
kirkkwang Jan 30, 2024
670784d
Merge branch 'i35-valkyrize-hyku' into i35-valkyrize-hyku-link-genera…
kirkkwang Jan 30, 2024
4622fa8
📚 Add docs regarding knapsack
jeremyf Jan 30, 2024
57616a8
🧹 Favor not using valkyrie for the spec
jeremyf Jan 30, 2024
2870a51
♻️ Only enable auto-redirect when Valkyrie enabled.
jeremyf Jan 30, 2024
78db82f
🧹 Configure Bulkrax
kirkkwang Jan 30, 2024
adb7393
Merge remote-tracking branch 'origin/i35-valkyrize-hyku-link-generati…
ShanaLMoore Jan 30, 2024
9fdd797
Revert "🧹 Remove files declared in Knapsack"
jeremyf Jan 31, 2024
c694ce0
Revert "remove bulkrax_identifier from Hyku"
ShanaLMoore Jan 31, 2024
d68d78e
♻️ Bump Hyrax ref
jeremyf Jan 31, 2024
3ac6ca9
♻️ Favor Hyrax::SolrService
jeremyf Jan 31, 2024
aa25008
Merge pull request #2160 from samvera/i35-favor-hyrax-solr-service
jeremyf Jan 31, 2024
3e27770
make find_by_bulkrax_identifier.rb more dynamic
ShanaLMoore Jan 31, 2024
9e82fde
Merge branch 'i35-valkyrize-hyku' of https://github.com/samvera/hyku …
ShanaLMoore Jan 31, 2024
ac313c7
Leverage updated IIIF Print
jeremyf Jan 31, 2024
f3c1c67
🧹 Appeasing rubocop
jeremyf Jan 31, 2024
78d26c5
find_by_source_identifier files moved to bulkrax
ShanaLMoore Jan 31, 2024
60e097e
Revert "find_by_source_identifier files moved to bulkrax"
ShanaLMoore Jan 31, 2024
e21d98e
update bulkrax and iiif_print versions
ShanaLMoore Feb 1, 2024
63aa39c
Merge branch 'main' into i35-valkyrize-hyku
ShanaLMoore Feb 1, 2024
4123e38
🧹 apply conditional to hyku indexing
ShanaLMoore Feb 1, 2024
bb112d0
💄 rubocop fix
ShanaLMoore Feb 1, 2024
dd61e0c
🧹 Fix set child flag
kirkkwang Feb 2, 2024
54f8d1f
Merge pull request #2161 from samvera/i35-valkyrize-hyku-relationships
jeremyf Feb 2, 2024
3459609
add guard for ActiveFedora's member_ids
ShanaLMoore Feb 2, 2024
7b2f3b3
Update Bulkrax and IiifPrint
ShanaLMoore Feb 2, 2024
89df09e
remove HYKU_IIIF_PRINT conditional
ShanaLMoore Feb 5, 2024
6516b00
update hyrax and iiif print
kirkkwang Feb 5, 2024
7b32e43
Valkyrize reindex rake tasks
ShanaLMoore Feb 5, 2024
11ed1b0
🐛 Ensure underlying change to permissions
jeremyf Feb 5, 2024
14a33e7
Fix for xray-rails not working
ShanaLMoore Feb 5, 2024
0b13c46
Merge branch 'main' into i35-valkyrize-hyku
jeremyf Feb 6, 2024
093c404
Bumping Hyrax version
jeremyf Feb 6, 2024
f99eb6f
Merge pull request #2163 from samvera/remove-iiif-print-env-var
jeremyf Feb 6, 2024
544b64f
💄rubocop fixes
ShanaLMoore Feb 6, 2024
ec12d8b
update hyrax, bulkrax, iiif_print
kirkkwang Feb 6, 2024
683e4d4
update hyrax
kirkkwang Feb 6, 2024
ecfe4a4
Pin Hyrax to functioning build
jeremyf Feb 6, 2024
a4d3125
Delete find_by_source_identifier_spec.rb
ShanaLMoore Feb 6, 2024
d30ae50
Update iiif_print
ShanaLMoore Feb 6, 2024
88d4cce
🧹 Remove `form` key from with_pdf_viewer
kirkkwang Feb 7, 2024
5c0ac17
🧹 Fix specs to reflect usage of Double Combo
jeremyf Feb 7, 2024
6084d80
🐛 Use registered instead of restricted
jeremyf Feb 7, 2024
fc45945
🧹 Amend spec to highlight double combo nuance
jeremyf Feb 7, 2024
5f70ffb
🧹 Rework lease expiry tests
jeremyf Feb 7, 2024
bfa71b7
💄 endless and ever appeasing of the coppers
jeremyf Feb 7, 2024
51bf79b
🧹 Fix broken spec
jeremyf Feb 7, 2024
a0d1013
💄 endless and ever appeasing of the cops
jeremyf Feb 7, 2024
f0329f3
Adding documentation
jeremyf Feb 7, 2024
8016058
🧹 Adjust AdminSet spec count to reflect query service
jeremyf Feb 8, 2024
38ceb5d
🧹 Address assumptive redirect for /concern/generic_work/
jeremyf Feb 8, 2024
818cdbc
🧹 Fixing redirect assumptions for insitutional visibility
jeremyf Feb 8, 2024
6a065dd
🧹 Favor up to date double_combo
jeremyf Feb 8, 2024
83738e1
Fixing a few specs to reflection Valkyriziation
jeremyf Feb 8, 2024
05ff3be
🧹 Updating Hyrax version
jeremyf Feb 8, 2024
ee2e5be
include Bulkrax helpers and update Bulkrax
kirkkwang Feb 8, 2024
a7e3ac4
Rework spec to not rely on reload
jeremyf Feb 8, 2024
02d8ef0
🧹 Fixing tests to use generic_resource_factory
jeremyf Feb 8, 2024
683311c
Fixing a spec that needs a #to_a
jeremyf Feb 8, 2024
9167757
♻️ Add Hyku.bulkrax_enabled?
jeremyf Feb 9, 2024
9c3af9e
♻️ Favor re-using the controller and hopefully routes
jeremyf Feb 9, 2024
d02aa82
Demonstrate how we're using lazy migrations and model naming
jeremyf Feb 9, 2024
ea7a714
♻️ Remove generated files
jeremyf Feb 9, 2024
bd301a2
🧹 endless and ever appeasing of the coppers
jeremyf Feb 12, 2024
d6fa335
☑️ Tidying up tests
jeremyf Feb 12, 2024
35286c3
☑️ Fixing a few broken tests
jeremyf Feb 12, 2024
2a32321
Move ability declarations out of loop, where loop not needed
jeremyf Feb 12, 2024
6bac079
💄 endless and ever appeasing of the coppers
jeremyf Feb 12, 2024
bedc3ad
☑️ Fill out require attributes
jeremyf Feb 12, 2024
c4b0c9e
☑️ Working through failing tests
jeremyf Feb 12, 2024
95436af
Fixing broken specs
jeremyf Feb 12, 2024
a160896
🐛 Refactor collection ability class
jeremyf Feb 12, 2024
2d2f1d4
Add elsif for FileSet and configure IIIF Print
kirkkwang Feb 12, 2024
c337df9
Bumping double_combo version
jeremyf Feb 14, 2024
16ef18a
Favor helper method over instance variable
jeremyf Feb 14, 2024
b96c954
☑️ We need to create a method to stub
jeremyf Feb 14, 2024
2fbffd8
☑️ Ever working towards tests
jeremyf Feb 14, 2024
69cd025
💄 endless and ever appeasing of the coppers
jeremyf Feb 14, 2024
afaf1a0
🎁 Add some FileSet interface friendliness
jeremyf Feb 14, 2024
59dbce3
☑️ Favor factory over process through actor stack
jeremyf Feb 14, 2024
90abb58
☑️ Adding tests for GenericWorkResrouce
jeremyf Feb 15, 2024
a99685d
🎁 Favor inheriting from admin_set
jeremyf Feb 15, 2024
b911729
☑️ Removing spec/factories defined Hyrax
jeremyf Feb 15, 2024
173053f
💄 endless and ever appeasing of the coppers
jeremyf Feb 15, 2024
4f372ec
♻️ Fixing some tests to rely on factories instead of actor
jeremyf Feb 15, 2024
d90ed63
🚧 Update Hyrax and IIIF Print
kirkkwang Feb 16, 2024
67834dd
☑️ Fixing a few tests by re-purposing some factories
jeremyf Feb 15, 2024
91368ee
WIP
jeremyf Feb 15, 2024
bf5f51b
Removing unneeded decorator and associated spec
jeremyf Feb 15, 2024
5a8430b
🧹 Ignore vendor/gems directory
jeremyf Feb 16, 2024
7f12d48
☑️ Adding documentation regarding Factories
jeremyf Feb 16, 2024
c106563
☑️ Fixing tests and factories for roles_service
jeremyf Feb 16, 2024
b53c20f
♻️ Favor site configuration for allow downloads
jeremyf Feb 16, 2024
3d2b85a
☑️ Fixing a broken test
jeremyf Feb 16, 2024
c3e9c88
Fixing a few broken specs, still some broken
jeremyf Feb 16, 2024
88edd03
💄 endless and ever appeasing of the coppers
jeremyf Feb 16, 2024
cf30c3e
Removing long-ago removable code
jeremyf Feb 16, 2024
fc4118a
Modify Collection & Admin Set Valkyrization
laritakr Feb 16, 2024
9de1b88
Coppers again
laritakr Feb 16, 2024
081378d
☑️ Favor explicit load of FactoryBot factories
jeremyf Feb 16, 2024
d53ac06
☑️ Working on getting more tests passing
jeremyf Feb 17, 2024
a6f1316
Merge branch 'i35-valkyrize-hyku' into i94-collections
jeremyf Feb 17, 2024
2bba104
Merge pull request #2164 from samvera/i94-collections
jeremyf Feb 17, 2024
c3ab645
Fixing ever more specs that keep breaking underneath me
jeremyf Feb 17, 2024
34bfb28
💄 endless and ever appeasing of the coppers
jeremyf Feb 17, 2024
08eadab
♻️ Verify AdminSetResource factory build
jeremyf Feb 18, 2024
d164944
Adding specs to demonstrate factories
jeremyf Feb 18, 2024
ff50f74
🧹 Avoid assuming factory-bot is available.
jeremyf Feb 18, 2024
848a270
🧹 We want to create admin set resources
jeremyf Feb 18, 2024
c1ab0e7
🧹 Fix broken spec due to not assuming admin group
jeremyf Feb 18, 2024
244898b
☑️ Fixing specs by re-using factories
jeremyf Feb 18, 2024
62bb52c
☑️ Adjust spec to use proper collection factory
jeremyf Feb 19, 2024
44ee888
☑️ Favor factory over instance double
jeremyf Feb 19, 2024
3660d46
☑️ Favor factory over explicit class
jeremyf Feb 19, 2024
275e22b
☑️ Favor factory over stub, and correct form class
jeremyf Feb 19, 2024
39c304f
☑️ Ensuring we start from a clean slate
jeremyf Feb 19, 2024
61ad72e
Fixing specs
jeremyf Feb 19, 2024
d9dccb4
☑️ Fixing tests squashing bugs that might show up
jeremyf Feb 19, 2024
6dd7401
Fixing specs to use resource classes
jeremyf Feb 19, 2024
82816af
Bumping version of IIIF Print
jeremyf Feb 19, 2024
da05047
🐛 Add .each to find_all call
jeremyf Feb 19, 2024
e4167d4
Fixing feature specs by ensuring admin_group
jeremyf Feb 19, 2024
628e5b6
🐛 Fixing a couple of different bugs
jeremyf Feb 19, 2024
5068597
💄 endless and ever appeasing of the coppers
jeremyf Feb 20, 2024
f118fbf
WIP
jeremyf Feb 20, 2024
36db042
♻️ Adding further collection ability testing
jeremyf Feb 20, 2024
4937da0
♻️ Put long list of objects into a loop
jeremyf Feb 20, 2024
15ec554
♻️ Adding more valkyrie native collection specs
jeremyf Feb 20, 2024
f4ca845
♻️ Re-arranging collection declarations
jeremyf Feb 20, 2024
3dcbcf5
♻️ Working in the spec mines regarding permission
jeremyf Feb 20, 2024
6891776
Adding specs for disable
jeremyf Feb 21, 2024
e1726df
♻️ Reworking specs and addressing significant typo
jeremyf Feb 21, 2024
cb576e2
🧹 Fix specs concerning collection management
jeremyf Feb 21, 2024
b7d2a37
Ever hacking on the specs
jeremyf Feb 21, 2024
0f76a4e
💄 endless and ever appeasing of the coppers
jeremyf Feb 21, 2024
8487114
🧹 Fix tests regarding collection management
jeremyf Feb 21, 2024
4d98b70
🧹 Fixing Hyrax::CollectionType#collections query
jeremyf Feb 21, 2024
5ca533f
🧹 Fixing a few broken specs
jeremyf Feb 21, 2024
39a13d5
🧹 Reworking factory process
jeremyf Feb 21, 2024
f9fffdb
💄 endless and ever appeasing of the coppers
jeremyf Feb 22, 2024
348c5a5
♻️ Favor member_ids_ssim over file_set_ids_ssim
jeremyf Feb 21, 2024
e7d82ee
☑️ Add role trait to reflect tests
jeremyf Feb 21, 2024
b9465cf
🧹 Set various presenter's with correct file_presenter_class
jeremyf Feb 21, 2024
3936726
Bumping the double_combo
jeremyf Feb 23, 2024
5680a18
Bumping version of IIIF Print and Bulkrax
jeremyf Feb 23, 2024
5227adb
💄 endless and ever appeasing of the coppers
jeremyf Feb 23, 2024
7377572
Adding tests to snare failing specs that work locally
jeremyf Feb 23, 2024
ca9d5ab
♻️ Working on factory bot creation of permission templates
jeremyf Feb 26, 2024
54d0a42
♻️ Fix spec harness for permissions
jeremyf Feb 27, 2024
917b2ce
📚 Add spec for factories to explain what happens
jeremyf Feb 27, 2024
ee48b61
Update double_combo and add bulkrax migrations
kirkkwang Feb 27, 2024
1824bc8
Fixing some underlying specs
jeremyf Feb 27, 2024
4968242
♻️ Fix selector issue
jeremyf Feb 27, 2024
c66ba49
☑️ Let These Specs Pass!
jeremyf Feb 27, 2024
e581054
☑️ Typo
jeremyf Feb 27, 2024
e04a9c5
💄 endless and ever appeasing of the coppers
jeremyf Feb 28, 2024
85772d7
Remove redundant declaration
jeremyf Feb 28, 2024
17c2fc7
☑️ Remove flakey tests
jeremyf Feb 28, 2024
4fd3954
☑️ Favor FactoryBot.valkyrie_create
jeremyf Feb 28, 2024
389e953
☑️ Add explicit setting of models before discovery factories
jeremyf Feb 28, 2024
649acac
🧹 Bump to new double_combo
jeremyf Feb 28, 2024
f59f070
Remove transient as the underlying problem fixed
jeremyf Feb 28, 2024
b5e74b7
♻️ Remove auto-creation of file
jeremyf Feb 28, 2024
3d7de4e
☑️ Favor Hyrax::SolrService.connection to match interface
jeremyf Feb 29, 2024
404f0c3
Bumping to new version of Hyrax double combo
jeremyf Feb 29, 2024
c80cff6
Update Hyrax
ShanaLMoore Feb 29, 2024
68f1750
Removing mocked tests that don't prove much
jeremyf Mar 1, 2024
21d8e70
Add embargo and lease to wings
kirkkwang Mar 1, 2024
bc596c0
Update riiif config to replace deprecated method
kirkkwang Mar 1, 2024
e138418
Adding tenant for request spec
jeremyf Mar 1, 2024
d0c7832
Updating factory spec to catch a failure
jeremyf Mar 1, 2024
dcbceab
Update Hyrax to move binaries
kirkkwang Mar 2, 2024
7c9cb22
start spec to test file set migration
kirkkwang Mar 4, 2024
b21c477
🐛 Fix Account switch bug
jeremyf Mar 4, 2024
89c5741
♻️ Remove method as duplicate of Hyrax
jeremyf Mar 4, 2024
7a9b7b8
🎁 Auto-magically migrate file sets and binaries
jeremyf Mar 4, 2024
1778bab
💄 endless and ever appeasing of the coppers
jeremyf Mar 4, 2024
92045f9
♻️ Remove stray puts statement
jeremyf Mar 4, 2024
f4e2732
Attempting to squash a flakey set of specs
jeremyf Mar 4, 2024
9072bac
Update #parent_path to account for various case statements
ShanaLMoore Mar 4, 2024
8d56979
💄 endless and ever appeasing of the coppers
jeremyf Mar 4, 2024
b0cbbac
I had to bail and copy the factories from Hyrax
jeremyf Mar 5, 2024
ff0a912
💄 endless and ever appeasing of the coppers
jeremyf Mar 5, 2024
c66865a
♻️ Disable some consistently failing specs
jeremyf Mar 5, 2024
a5771f8
Update hyrax version
ShanaLMoore Mar 6, 2024
17dea1b
Merge branch 'i35-valkyrize-hyku' of https://github.com/samvera/hyku …
ShanaLMoore Mar 6, 2024
47cbfbd
Merge branch 'main' into i35-valkyrize-hyku
jeremyf Mar 6, 2024
6a4f1e5
Revert "I had to bail and copy the factories from Hyrax"
jeremyf Mar 6, 2024
659d60c
Update Hyrax
ShanaLMoore Mar 6, 2024
66e9831
Bumping Hyrax version
jeremyf Mar 7, 2024
4ac5e1e
Updating Hyrax to latest build with FS fixes
jeremyf Mar 11, 2024
48133b1
Merge branch 'i35-valkyrize-hyku' of https://github.com/samvera/hyku …
ShanaLMoore Mar 11, 2024
1cd5ca1
Merge branch 'i35-valkyrize-hyku' of https://github.com/samvera/hyku …
ShanaLMoore Mar 11, 2024
da5c523
♻️ Update Hyku to new Double Combo and config file_set_model
jeremyf Mar 12, 2024
3749af5
💄 endless and ever appeasing of the coppers
jeremyf Mar 12, 2024
c9c1185
Addressing potential routing errors
jeremyf Mar 12, 2024
e7718b2
Remove indexing of collection membership
jeremyf Mar 12, 2024
f41ba15
♻️ Adding Hyku::Application.work_types (see docs)
jeremyf Mar 13, 2024
61c863d
♻️ Configure `Bulkrax.*_model_class` methods
jeremyf Mar 13, 2024
05fd2eb
copy Rob's reprocessor script from GBH into Hyku
bkiahstroud Mar 14, 2024
d1d11bc
resolve most rubocop warnings
bkiahstroud Mar 14, 2024
d0e27dc
update rubocop_todo
bkiahstroud Mar 14, 2024
3fbf2f4
Load HykuKnapsack decorators
kirkkwang Mar 15, 2024
06350fc
temp: debug build issues
ShanaLMoore Mar 18, 2024
4375a29
Revert "temp: debug build issues"
ShanaLMoore Mar 18, 2024
29ef204
Update Bulkrax
kirkkwang Mar 19, 2024
37b16e0
Update Bulkrax
ShanaLMoore Mar 19, 2024
fc85d08
Merge branch 'i35-valkyrize-hyku' of https://github.com/samvera/hyku …
ShanaLMoore Mar 19, 2024
7ff49ca
Update Bulkrax and Hyrax
kirkkwang Mar 21, 2024
0642931
🧹 Update bulkrax gem
ShanaLMoore Mar 21, 2024
d87e4ed
Update Bulkrax
kirkkwang Mar 21, 2024
ae46a17
🐛 Fix undefined local variable iiif_print
kirkkwang Mar 21, 2024
9614850
🐛 Fix collection membership bug (#2169)
laritakr Mar 22, 2024
a327222
update Bulkrax
kirkkwang Mar 26, 2024
6940b4c
Show PDF.js viewer when PDF.js FlipFlop is true
ShanaLMoore Mar 26, 2024
29963d3
revert previous commit and update logic of #show_pdf_viewer instead
ShanaLMoore Mar 27, 2024
1512867
Merge pull request #2171 from samvera/i185-edit-pdf-work-bug
ShanaLMoore Mar 27, 2024
a32664d
Update valkyrie gem
ShanaLMoore Mar 27, 2024
5542205
update valkyrie gem
ShanaLMoore Mar 27, 2024
f0f5421
Update bulkrax to fix bug
laritakr Mar 28, 2024
cfa48b4
Merge branch 'main' into i35-valkyrize-hyku
jeremyf Mar 28, 2024
093251b
🧹 Clean up featured works and collections
kirkkwang Mar 29, 2024
75a9d99
Update IiifPrint (#2172)
laritakr Mar 29, 2024
65c9abb
♻️ Favor method_missing over delegation
jeremyf Apr 1, 2024
fb6adf7
♻️ Remove config that was there for flakey tests
jeremyf Apr 1, 2024
5e97d78
Update app/forms/hyrax/forms/admin/appearance_decorator.rb
jeremyf Apr 1, 2024
5b61235
Favor published valkyrie gem version
jeremyf Apr 1, 2024
d3df1e0
🎁 Valkyrize Reindex jobs (#2173)
laritakr Apr 1, 2024
5a90fcf
update gemfile to add support for sentry
ShanaLMoore Apr 1, 2024
2ec7b41
🗡 Stab in the dark at fixing an intermittent bug
jeremyf Apr 1, 2024
a8c49fd
add conditional to support HykuUp Knapsack specs
ShanaLMoore Apr 1, 2024
8cf0e95
add conditional to support HykuUp Knapsack specs
ShanaLMoore Apr 1, 2024
ad48579
Merge branch 'i35-valkyrize-hyku' of https://github.com/samvera/hyku …
ShanaLMoore Apr 1, 2024
f745207
:lipstick: rubocop fix
ShanaLMoore Apr 1, 2024
289ca62
:lipstick: rubocop fix
ShanaLMoore Apr 1, 2024
08779c1
Merge branch 'i35-valkyrize-hyku' of https://github.com/samvera/hyku …
ShanaLMoore Apr 1, 2024
19e5f3a
🧹 Add core to hash in spec
kirkkwang Apr 2, 2024
25f22cc
🧹 Add storage/files as a persisted volumn
kirkkwang Apr 2, 2024
a19960f
update bulkrax, hyrax, iiif_print
kirkkwang Apr 2, 2024
8e390ee
bump to rc3
kirkkwang Apr 2, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 4 additions & 0 deletions .env
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,12 @@ SOLR_PORT=8983
SOLR_URL=http://solr:SolrRocks@solr:8983/solr/
TB_RSPEC_FORMATTER=progress
TB_RSPEC_OPTIONS="--format RspecJunitFormatter --out rspec.xml"
VALKYRIE_ID_TYPE=string

# Comment out these 5 for single tenancy / Uncomment for multi
HYKU_ADMIN_HOST=hyku.test
HYKU_ADMIN_ONLY_TENANT_CREATION=false
HYKU_BLOCK_VALKYRIE_REDIRECT=false
HYKU_DEFAULT_HOST=%{tenant}.hyku.test
HYKU_ROOT_HOST=hyku.test
HYKU_MULTITENANT=true
Expand Down Expand Up @@ -67,3 +69,5 @@ HYKU_RESTRICT_CREATE_AND_DESTROY_PERMISSIONS=true
# AND comment this out
HYRAX_ANALYTICS=false
##END## Enable Google Analytics

HYRAX_VALKYRIE=true
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ rerun.txt
pickle-email-*.html
solr_db_initialized
fits.log
/storage/files

## Environment normalization:
/.bundle
Expand Down
1 change: 1 addition & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ Metrics/BlockLength:
- 'lib/tasks/*.rake'
- 'spec/**/*.rb'
- 'tasks/benchmark.rake'
- 'config/application.rb'

Style/AsciiComments:
Enabled: false
Expand Down
10 changes: 7 additions & 3 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ gem 'blacklight_range_limit'
gem 'bolognese', '>= 1.9.10'
gem 'bootstrap', '~> 4.6'
gem 'bootstrap-datepicker-rails'
gem 'bulkrax', '~> 5.4'
gem 'bulkrax', github: 'samvera/bulkrax', branch: 'main'
gem 'byebug', group: %i[development test]
gem 'capybara', group: %i[test]
gem 'capybara-screenshot', '~> 1.0', group: %i[test]
Expand All @@ -54,7 +54,7 @@ gem 'hyrax-doi', github: 'samvera-labs/hyrax-doi', branch: 'rails_hyrax_upgrade'
gem 'hyrax-iiif_av', github: 'samvera-labs/hyrax-iiif_av', branch: 'rails_hyrax_upgrade'
gem 'i18n-debug', require: false, group: %i[development test]
gem 'i18n-tasks', group: %i[development test]
gem 'iiif_print', github: 'scientist-softserv/iiif_print', branch: 'rails_hyrax_upgrade'
gem 'iiif_print', github: 'scientist-softserv/iiif_print', branch: 'main'
gem 'jbuilder', '~> 2.5'
gem 'jquery-rails' # Use jquery as the JavaScript library
# The maintainers yanked 0.3.2 version (see https://github.com/dryruby/json-canonicalization/issues/2)
Expand Down Expand Up @@ -109,9 +109,12 @@ gem 'terser' # to support the Safe Navigation / Optional Chaining operator (?.)
gem 'tether-rails'
gem 'turbolinks', '~> 5'
gem 'twitter-typeahead-rails', '0.11.1.pre.corejavascript'
gem 'valkyrie', '~> 3.0', '>= 3.1.4' # There's a patch in 3.1.4 that we want
gem 'web-console', '>= 3.3.0', group: %i[development] # <%= console %> in views
gem 'webdrivers', '~> 4.7.0', group: %i[test]
gem 'webmock', group: %i[test]
# Enabling the following gem breaks sidekiq. To Enable: assets.debug must be set to true in config/development.rb
# gem "xray-rails", git: "https://github.com/brentd/xray-rails.git", branch: "bugs/ruby-3.0.0", group: %i[development]

# This gem does nothing by default, but is instead a tool to ease developer flow
# and place overrides, themes and deployment code.
Expand All @@ -131,7 +134,8 @@ gem 'webmock', group: %i[test]
#
# Thus the hopefully descriptive `required_for_knapsack_instances`.
#
# tl;dr - Have a local `required_for_knapsack_instances` branch on your knapsack repository
# tl;dr - Have a local `required_for_knapsack_instances` branch on your knapsack repository and 99%
# of the time use the `samvera-labs/hyku_knapsack` remote branch.
gem 'hyku_knapsack', github: 'samvera-labs/hyku_knapsack', branch: 'required_for_knapsack_instances'

# rubocop:enable Layout/LineLength
69 changes: 47 additions & 22 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ GIT
specs:
hyku_knapsack (0.0.1)
rails (>= 5.2.0)
sentry-rails
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did sentry become a hyku dependency?

Copy link
Collaborator Author

@ShanaLMoore ShanaLMoore Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it not be? We added sentry for hyku up knapsack and knapsack prime, but now that you question it I wonder if we should've added it to bundler.d instead (within each repo)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: rip it out of hyku and put it in bundler.d of the respective repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to have come about because we added sentry (et al) to the gem spec of knapsack; and when we bundled along came sentry. This is definitely a surprise as we think about traditional directional dependencies; that is we think of Knapsack as laying on top of Hyku; but in reality it's a much more convoluted relationship.

sentry-ruby
sentry-sidekiq

GIT
remote: https://github.com/samvera-labs/hyrax-doi.git
Expand All @@ -123,12 +126,34 @@ GIT
iiif_manifest (> 0.5)
rails (>= 5.1, < 8.0)

GIT
remote: https://github.com/samvera/bulkrax.git
revision: 1048453a4d99a6fba4b10531c2dc3a67a51c4c50
branch: main
specs:
bulkrax (8.0.0)
bagit (~> 0.4.6)
coderay
denormalize_fields
iso8601 (~> 0.9.0)
kaminari
language_list (~> 1.2, >= 1.2.1)
libxml-ruby (~> 3.2.4)
loofah (>= 2.2.3)
marcel
oai (>= 0.4, < 2.x)
rack (>= 2.0.6)
rails (>= 5.1.6)
rdf (>= 2.0.2, < 4.0)
rubyzip
simple_form

GIT
remote: https://github.com/samvera/hyrax.git
revision: cc86fa88456b2d5021e52f8d8842128f960215d0
revision: a5a0ae9e56df857a92fc53ae86216cbb007db47a
branch: double_combo
specs:
hyrax (5.0.0.rc3)
hyrax (5.0.0)
active-fedora (~> 14.0)
almond-rails (~> 0.1)
awesome_nested_set (~> 3.1)
Expand Down Expand Up @@ -197,8 +222,8 @@ GIT

GIT
remote: https://github.com/scientist-softserv/iiif_print.git
revision: cad2cf33fc07ec2abb5b6834a858b5ed74903c12
branch: rails_hyrax_upgrade
revision: eed88649c00e7b78f33425151fafe793db75ac82
branch: main
specs:
iiif_print (1.0.0)
blacklight_iiif_search (>= 1.0, < 3.0)
Expand Down Expand Up @@ -383,20 +408,6 @@ GEM
signet (~> 0.8)
typhoeus
builder (3.2.4)
bulkrax (5.5.0)
bagit (~> 0.4)
coderay
iso8601 (~> 0.9.0)
kaminari
language_list (~> 1.2, >= 1.2.1)
libxml-ruby (~> 3.2.4)
loofah (>= 2.2.3)
oai (>= 0.4, < 2.x)
rack (>= 2.0.6)
rails (>= 5.1.6)
rdf (>= 2.0.2, < 4.0)
rubyzip
simple_form
byebug (11.1.3)
cancancan (3.5.0)
capybara (3.39.2)
Expand Down Expand Up @@ -454,6 +465,8 @@ GEM
database_cleaner-core (2.0.1)
date (3.3.4)
declarative (0.0.20)
denormalize_fields (1.3.0)
activerecord (>= 4.1.14, < 8.0.0)
deprecation (1.1.0)
activesupport
derivative-rodeo (0.5.3)
Expand Down Expand Up @@ -559,7 +572,7 @@ GEM
ffi (>= 1.15.0)
excon (0.71.1)
execjs (2.9.1)
factory_bot (6.4.2)
factory_bot (6.4.6)
activesupport (>= 5.0.0)
factory_bot_rails (6.4.2)
factory_bot (~> 6.4)
Expand Down Expand Up @@ -1146,7 +1159,7 @@ GEM
rspec-mocks (3.12.6)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.12.0)
rspec-rails (6.1.0)
rspec-rails (6.1.1)
actionpack (>= 6.1)
activesupport (>= 6.1)
railties (>= 6.1)
Expand Down Expand Up @@ -1214,6 +1227,15 @@ GEM
rexml (~> 3.2, >= 3.2.5)
rubyzip (>= 1.2.2, < 3.0)
websocket (~> 1.0)
sentry-rails (5.17.1)
railties (>= 5.0)
sentry-ruby (~> 5.17.1)
sentry-ruby (5.17.1)
bigdecimal
concurrent-ruby (~> 1.0, >= 1.0.2)
sentry-sidekiq (5.17.1)
sentry-ruby (~> 5.17.1)
sidekiq (>= 3.0)
shacl (0.3.0)
json-ld (~> 3.2)
rdf (~> 3.2, >= 3.2.8)
Expand Down Expand Up @@ -1346,7 +1368,7 @@ GEM
validate_url (1.0.15)
activemodel (>= 3.0.0)
public_suffix
valkyrie (3.1.1)
valkyrie (3.1.4)
activemodel
activesupport
dry-struct
Expand Down Expand Up @@ -1402,6 +1424,8 @@ GEM

PLATFORMS
aarch64-linux-musl
arm64-darwin-23
ruby
x86_64-linux-musl

DEPENDENCIES
Expand All @@ -1419,7 +1443,7 @@ DEPENDENCIES
bolognese (>= 1.9.10)
bootstrap (~> 4.6)
bootstrap-datepicker-rails
bulkrax (~> 5.4)
bulkrax!
byebug
capybara
capybara-screenshot (~> 1.0)
Expand Down Expand Up @@ -1500,6 +1524,7 @@ DEPENDENCIES
tether-rails
turbolinks (~> 5)
twitter-typeahead-rails (= 0.11.1.pre.corejavascript)
valkyrie (~> 3.0, >= 3.1.4)
web-console (>= 3.3.0)
webdrivers (~> 4.7.0)
webmock
Expand Down
42 changes: 34 additions & 8 deletions app/assets/stylesheets/hyku.scss
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
}
}

.dashboard .form-tab-content label {
font-weight: 700;
}

@media (min-width: 768px) {
.logo-set {
display: flex;
Expand Down Expand Up @@ -467,6 +471,24 @@ body.public-facing {
padding: 0;
}

.dd3-handle {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule set contains (17/10) properties

position: absolute; margin: 0; left: 0; top: 0; cursor: pointer; width: 30px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered background, border, border-bottom-right-radius, border-top-right-radius, cursor, left, margin, overflow, position, text-indent, top, white-space, width, z-index
Property 'cursor' should be placed on own line
Property 'left' should be placed on own line
Property 'margin' should be placed on own line
Property 'top' should be placed on own line
Property 'width' should be placed on own line

text-indent: 100px;
white-space: nowrap; overflow: hidden;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Property 'overflow' should be placed on own line

border: 1px solid #aaa;
background: #ddd;
background: -webkit-linear-gradient(top, #ddd 0%, #bbb 100%);
background: -moz-linear-gradient(top, #ddd 0%, #bbb 100%);
background: linear-gradient(top, #ddd 0%, #bbb 100%);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Property background already defined on line 479

border-top-right-radius: 0;
border-bottom-right-radius: 0;
z-index: 1;
}

.dd3-content .card-body {
background: transparent;
}

.d-flex {
display: flex;
}
Expand Down Expand Up @@ -532,6 +554,7 @@ span.constraint-value p, .facet-values p {
// style the analytics button to match citations button
#stats {
margin-top: 10px;

@media (min-width: 576px) {
max-width: 300px;
}
Expand All @@ -549,25 +572,28 @@ span.constraint-value p, .facet-values p {
// collection show page styles

.space-between {
justify-content: space-between;
align-items: center;
justify-content: space-between;
}

.hyc-banner {
padding: 15px;
.hyc-bugs .hyc-created-by, .hyc-bugs .hyc-last-updated, .hyc-title {
.hyc-bugs .hyc-created-by,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be preceded by an empty line

.hyc-bugs .hyc-last-updated,
.hyc-title {
padding: 0;
}

.hyc-item-count {
margin: 0;
background: rgba(255, 255, 255, 0.75);
padding: 10px;
border-radius: 0.5em;
color: #333;
margin: 0;
padding: 10px;
}

.hyc-bugs div, div {
.hyc-bugs div,
div {
position: relative;
}
}
Expand All @@ -588,7 +614,7 @@ span.constraint-value p, .facet-values p {
}

.mb-2 {
margin-bottom: .5em;
margin-bottom: 0.5em;
}

.mb-5 {
Expand All @@ -605,13 +631,13 @@ span.constraint-value p, .facet-values p {
}

.py-0 {
padding-top: 0;
padding-bottom: 0;
padding-top: 0;
}

.py-4 {
padding-top: 2em;
padding-bottom: 2em;
padding-top: 2em;
}

.d-block {
Expand Down
4 changes: 2 additions & 2 deletions app/assets/stylesheets/hyrax.scss
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@

// for catalog search result snippets
.highlight {
background: yellow;
background: #ffff00;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces

font-weight: 700;
}
}
2 changes: 1 addition & 1 deletion app/assets/stylesheets/viewer.scss
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@
.video-embed-viewer {
aspect-ratio: 16 / 9;
width: 100%;
}
}
2 changes: 1 addition & 1 deletion app/controllers/application_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def api_or_pdf?
end

def staging?
['staging'].include?(Rails.env)
Rails.env.staging? # rubocop:disable Rails/UnknownEnv
end

def authenticate_if_needed
Expand Down
Loading
Loading