Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-1034: Combine code coverage from both Javascript and Ruby code #1520

Merged
merged 12 commits into from
Feb 16, 2024

Conversation

StephenHulme
Copy link
Contributor

@StephenHulme StephenHulme commented Dec 15, 2023

Requirement

As a developer I would like to track code coverage for both Ruby and Javascript code within a single application/repo. Currently only Ruby code coverage is monitored and Javascript coverage is ignored.

It should be possible to easily review coverage online on both a per-PR and a repo-as-a-whole basis.

Progress update

While I think it is possible to combine the coverage reports from two different test processes (as demonstrated in this PR), I have not been able to view the new Javascript coverage on Code Climate's interface.

As such, I recommend that we switch to using Codecov for coverage, as we do in other repositories such as Traction-Service.

This change requires team input and should be suggested at the next retro.

UPDATE: switching to CodeCov approved, with a transition period where both services are used simultenously.

Changes proposed in this pull request

  • Refactor language test files
  • Upload test results to CodeCov
    • Test results are uploaded to CodeCov individually and are merged on their side

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@StephenHulme StephenHulme self-assigned this Dec 18, 2023
@StephenHulme StephenHulme added technical risk Deployment process improvement Housekeeping Housekeeping Size: S Small - low effort & risk Value: 4 Value to the insitute is high Technical Debt and removed Housekeeping Housekeeping technical risk labels Dec 19, 2023
@StephenHulme StephenHulme changed the title build: upload and combine coverage of Javascript code Combine code coverage from both Javascript and Ruby code Dec 19, 2023
@StephenHulme StephenHulme changed the title Combine code coverage from both Javascript and Ruby code DPL-1034: Combine code coverage from both Javascript and Ruby code Dec 19, 2023
Copy link

codecov bot commented Feb 13, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link

codeclimate bot commented Feb 14, 2024

Code Climate has analyzed commit ffdb01b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.1% (0.0% change).

View more on Code Climate.

@StephenHulme StephenHulme merged commit 29431cc into develop Feb 16, 2024
12 checks passed
@StephenHulme StephenHulme deleted the sh51/combine-coverage branch February 16, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deployment process improvement Size: S Small - low effort & risk Technical Debt Value: 4 Value to the insitute is high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants