-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPL-1034: Combine code coverage from both Javascript and Ruby code #1520
Conversation
4baa742
to
f2cdc35
Compare
TODO: add back code-climate for transition
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Code Climate has analyzed commit ffdb01b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.1% (0.0% change). View more on Code Climate. |
Requirement
As a developer I would like to track code coverage for both Ruby and Javascript code within a single application/repo. Currently only Ruby code coverage is monitored and Javascript coverage is ignored.
It should be possible to easily review coverage online on both a per-PR and a repo-as-a-whole basis.
Progress update
While I think it is possible to combine the coverage reports from two different test processes (as demonstrated in this PR), I have not been able to view the new Javascript coverage on Code Climate's interface.
As such, I recommend that we switch to using Codecov for coverage, as we do in other repositories such as Traction-Service.
This change requires team input and should be suggested at the next retro.
UPDATE: switching to CodeCov approved, with a transition period where both services are used simultenously.
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version