Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-1047-16: Upgrade Node to v16 #1804

Merged
merged 14 commits into from
Aug 5, 2024
Merged

DPL-1047-16: Upgrade Node to v16 #1804

merged 14 commits into from
Aug 5, 2024

Conversation

StephenHulme
Copy link
Contributor

@StephenHulme StephenHulme commented Jul 22, 2024

Moves closer to closing #1541, as upgrading to v20 is non-trivial (see #1555)
Preceeds #1645

Changes proposed in this pull request

  • Upgrad Node 14 -> 16

Version 16 checklist:

  • rm -fr node_modules
  • Update .nvmrc
  • nvm install
  • nvm use
  • yarn install --dev
  • yarn prettier --write .
  • yarn lint
  • yarn test
  • ./compile-build
  • docker-compose build --no-cache
  • docker-compose up

Deployment Instructions

  • Needs to be thoroughly tested in UAT before merging and deploying

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.40%. Comparing base (baf1b58) to head (3fe50ed).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1804   +/-   ##
========================================
  Coverage    91.40%   91.40%           
========================================
  Files          376      376           
  Lines         7656     7656           
========================================
  Hits          6998     6998           
  Misses         658      658           
Flag Coverage Δ
javascript 93.65% <100.00%> (ø)
pull_request 91.40% <100.00%> (?)
push 91.40% <100.00%> (ø)
ruby 91.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StephenHulme StephenHulme changed the title DPL-1047: Node 16 upgrade DPL-1047-16: Node 16 upgrade Jul 24, 2024
@StephenHulme StephenHulme changed the title DPL-1047-16: Node 16 upgrade DPL-1047-16: Upgrade Node to v16 Jul 24, 2024
Copy link

codeclimate bot commented Aug 5, 2024

Code Climate has analyzed commit 5175a78 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.

@StephenHulme StephenHulme merged commit 00da919 into develop Aug 5, 2024
10 checks passed
@StephenHulme StephenHulme deleted the dpl-1047-16-upgrade branch August 5, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants