-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPL-1047-16: Upgrade Node to v16 #1804
Conversation
TODO: this should be fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1804 +/- ##
========================================
Coverage 91.40% 91.40%
========================================
Files 376 376
Lines 7656 7656
========================================
Hits 6998 6998
Misses 658 658
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Code Climate has analyzed commit 5175a78 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 91.1% (0.0% change). View more on Code Climate. |
Moves closer to closing #1541, as upgrading to v20 is non-trivial (see #1555)
Preceeds #1645
Changes proposed in this pull request
Version 16 checklist:
rm -fr node_modules
.nvmrc
nvm install
nvm use
yarn install --dev
yarn prettier --write .
yarn lint
yarn test
./compile-build
docker-compose build --no-cache
docker-compose up
Deployment Instructions
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version