-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y24-271 - LCM Triomics Configuration + Integration Suite Tests #4305
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4305 +/- ##
===========================================
- Coverage 87.60% 87.56% -0.04%
===========================================
Files 1383 1383
Lines 29875 29875
===========================================
- Hits 26172 26161 -11
- Misses 3703 3714 +11 ☔ View full report in Codecov by Sentry. |
11ceac0
to
7232edd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions - up for debate. And maybe we commit this version first and then do the changes later in Y24-266.
config/default_records/request_types/018_limber_lcm_triomics_request_types.wip.yml
Outdated
Show resolved
Hide resolved
config/default_records/request_types/018_limber_lcm_triomics_request_types.wip.yml
Outdated
Show resolved
Hide resolved
config/default_records/submission_templates/014_lcm_triomics_submission_templates.wip.yml
Outdated
Show resolved
Hide resolved
config/default_records/product_catalogues/013_lcm_triomics_catalogue.wip.yml
Outdated
Show resolved
Hide resolved
config/default_records/request_types/018_limber_lcm_triomics_request_types.wip.yml
Outdated
Show resolved
Hide resolved
config/default_records/submission_templates/014_lcm_triomics_submission_templates.wip.yml
Outdated
Show resolved
Hide resolved
config/default_records/submission_templates/014_lcm_triomics_submission_templates.wip.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just suggested changes to the comments in the submission template file.
I assume we'll add a 2nd submission template for the WGS route in another story.
config/default_records/submission_templates/014_lcm_triomics_submission_templates.wip.yml
Outdated
Show resolved
Hide resolved
config/default_records/submission_templates/014_lcm_triomics_submission_templates.wip.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have suggested a few changes. The request type name is particularly important as it is visible to the user.
config/default_records/request_types/018_limber_lcm_triomics_request_types.wip.yml
Outdated
Show resolved
Hide resolved
config/default_records/request_types/018_limber_lcm_triomics_request_types.wip.yml
Show resolved
Hide resolved
config/default_records/plate_purposes/013_lcm_triomics_plate_purposes.wip.yml
Outdated
Show resolved
Hide resolved
config/default_records/request_types/018_limber_lcm_triomics_request_types.wip.yml
Outdated
Show resolved
Hide resolved
config/default_records/submission_templates/014_lcm_triomics_submission_templates.wip.yml
Outdated
Show resolved
Hide resolved
Also merge develop back into your branch to get the updates to make all tests pass. |
fbf8c0a
to
59bcfc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes as well.
Closes #4291
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version