Populate 'sample_public_name' column values with 'sanger_sample_id' column values for RVI-prefixed samples

[sabrine33]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.29%. Comparing base (90b2405) to head (ddc7ce2).
Report is 9 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4565      +/-   ##
===========================================
+ Coverage    89.25%   89.29%   +0.03%     
===========================================
  Files         1406     1406              
  Lines        30007    30007              
===========================================
+ Hits         26783    26795      +12     
+ Misses        3224     3212      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[StephenHulme]

I'm not as familiar with the data and linkages, but from a rails point of view this looks fine.

Would you please update the PR title to be more human readable?

[sabrine33]

I'm not as familiar with the data and linkages, but from a rails point of view this looks fine.

Would you please update the PR title to be more human readable?

I updated the title, thanks

[dasunpubudumal]

Do you think that this is more suitable to be a Rake task than a migration?

It does not involve any schema updates, and it only has data updates.

[sabrine33]

Do you think that this is more suitable to be a Rake task than a migration?

It does not involve any schema updates, and it only has data updates.

I agree. I initially created it as a Rake task, but later I discovered that the data was being updated/populated through a migration. So, I updated it to follow the convention of doing things.