Replace ansible.builtin.pause with ansible.builtin.wait_for #29
Conversation
This fixes an issue when running with strategy free: > ERROR! The 'ansible.builtin.pause' module bypasses the host loop, which > is currently not supported in the free strategy and would instead > execute for every host in the inventory list. Furthermore, the documentation for ansible.builtin.pause states: To pause/wait/sleep per host, use the ansible.builtin.wait_for module. See https://docs.ansible.com/ansible/latest/collections/ansible/builtin/pause_module.html
There was a problem hiding this comment.
Btw, someone should add a comment here to understand the need for this 10s pause.
There was a problem hiding this comment.
git blame said that the first introduction of this was made by @berndfinger, do you remember something about this?
There was a problem hiding this comment.
@Wabri I am shown in git blame because I, if I remember correctly, created the initial version by transferring it from another repo.
@rainerleber - I see that you changed some lines in this file after the initial version. Do you know more about why the pause module was used here?
There was a problem hiding this comment.
i looks like this wait in the main.yaml could be removed, maybe it's an historic entry to work as expected before we included the modules there was a script to discover the facts
|
Is there a timeline to get this enhancement change into mainline? |
This fixes an issue when running with strategy free:
Furthermore, the documentation for ansible.builtin.pause states: To pause/wait/sleep per host, use the ansible.builtin.wait_for module.
See https://docs.ansible.com/ansible/latest/collections/ansible/builtin/pause_module.html