Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ansible.builtin.pause with ansible.builtin.wait_for #29

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Replace ansible.builtin.pause with ansible.builtin.wait_for #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions roles/sap_control/tasks/functions/restart_sapstartsrv.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,5 @@
register: sap_start_sapstartsrv

- name: SAPstartsrv - Wait for 10 seconds for sapstartsrv to initialize
ansible.builtin.pause:
seconds: 10
ansible.builtin.wait_for:
timeout: 10
4 changes: 2 additions & 2 deletions roles/sap_control/tasks/main.yml
View file
Open in desktop
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, someone should add a comment here to understand the need for this 10s pause.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git blame said that the first introduction of this was made by @berndfinger, do you remember something about this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wabri I am shown in git blame because I, if I remember correctly, created the initial version by transferring it from another repo.

@rainerleber - I see that you changed some lines in this file after the initial version. Do you know more about why the pause module was used here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i looks like this wait in the main.yaml could be removed, maybe it's an historic entry to work as expected before we included the modules there was a script to discover the facts

Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@
msg: "{{ sap_facts_register.sap_facts }}"

- name: pause for 10 Seconds
ansible.builtin.pause:
seconds: 10
ansible.builtin.wait_for:
timeout: 10

# Debugging stuff
- name: Display parameters for runtime
Expand Down
Loading