-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Use $GITHUB_ACTION_PATH to locate pixi.lock for downstream users #96
Conversation
I'm not sure, but I think with the change to composite action we need to also be specific about this repo's filepaths by using `GITHUB_ACTION_PATH` . I tried to use `0.6.0` downstream and I got an error `Failed to generate cache key: Error: ENOENT: no such file or directory, open 'pixi.lock'
Can you link to the failure downstream? If it is complaining about the lock file that seems different. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MridulS To see if this actually works could you (momentarily and then revert it) switch in the CI the local action path
uses: ./ |
to use your fork's MridulS-patch-1
branch?
edit: Ah, sorry I see that this is a branch on the main repo. I just misread your branch name. Let me try this quickly using my fork and your changes on a different branch.
Co-authored-by: Matthew Feickert <[email protected]>
@MridulS Okay, yes that works. Thank you! What I did to test was to push your $ git branch --all | grep patch
MridulS-patch-1
* debug-ci-with-mriduls-patch
matthewfeickert/MridulS-patch-1
remotes/matthewfeickert/MridulS-patch-1
remotes/origin/MridulS-patch-1
remotes/origin/debug-ci-with-mriduls-patch and then run the CI manually on another branch using my fork as the target $ git branch
MridulS-patch-1
* debug-ci-with-mriduls-patch
main
matthewfeickert/MridulS-patch-1
$ git diff origin/main
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index cdd4d13..19d0427 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -48,13 +48,13 @@ jobs:
run: python -m zipfile --list dist/test_package-*.whl
- name: Test upload
- uses: ./
+ uses: matthewfeickert/upload-nightly-action@MridulS-patch-1
with:
artifacts_path: dist
anaconda_nightly_upload_token: ${{ secrets.UPLOAD_TOKEN }}
- name: Test upload that forces removal first
- uses: ./
+ uses: matthewfeickert/upload-nightly-action@MridulS-patch-1
with:
artifacts_path: dist
anaconda_nightly_upload_token: ${{ secrets.UPLOAD_TOKEN }}
@@ -67,7 +67,7 @@ jobs:
python -m build --outdir ./dist tests/test_package
- name: Test upload with non-main label
- uses: ./
+ uses: matthewfeickert/upload-nightly-action@MridulS-patch-1
with:
artifacts_path: dist
anaconda_nightly_upload_token: ${{ secrets.UPLOAD_TOKEN }}
@@ -81,7 +81,7 @@ jobs:
python -m build --outdir ./dist tests/test_package
- name: Test upload with multiple labels
- uses: ./
+ uses: matthewfeickert/upload-nightly-action@MridulS-patch-1
with:
artifacts_path: dist
anaconda_nightly_upload_token: ${{ secrets.UPLOAD_TOKEN }} That works. 👍 We need better testing though apparently. I'm going to write some longer squash and merge commit message and then I'll merge this and get a patch release out. |
Thanks @matthewfeickert!
Testing actions inside actions are tricky anyway. I think it's still not done yet! We need to add |
I missed this in #96 but we need to be explicit while using `pixi run` too. I was tripping into `could not find pixi.toml or pyproject.toml which is configured to use pixi` while on the `pixi run` step downstream.
I'm not sure, but I think with the change to composite action we need to also be specific about this repo's filepaths by using
GITHUB_ACTION_PATH
. I tried to use0.6.0
downstream and I got an error `Failed to generate cache key: Error: ENOENT: no such file or directory, open 'pixi.lock'Squash and merge commit message