⚙️ Adding derivative_rodeo as dev dependency #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why as a development dependency? Because the DerivativeRodeo introduces a dependency on Faraday >= 1. And the Valkyrie and ActiveFedora versions which Hyrax 2 and 3 depend on have a Faraday dependency of < 1. I am pushing this up so that I can begin development on the ingest aspect of the Derivative Rodeo. Also to see how this resolves in our CI setup and to see the impact, if any on downstream implementations of IIIF Print (e.g. Adventist, British Library, ATLA, PALNI/PALCI, UTK, and others). The plan is to determine if we want to have this Faraday conflict setup or if we want to swap out something else in the underlying DerivativeRodeo. Related to: - https://github.com/scientist-softserv/adventist-dl/issues/330 - #219 - #220
laritakr
approved these changes
May 24, 2023
jeremyf
added a commit
that referenced
this pull request
May 24, 2023
As written, this is a draft commit. Its purpose is to share the implementation details and how we might incorporate the DerivativeRodeo into the derivative generation. This draft will break the build as it does not include adding the DerivativeRodeo as a dependency. An ongoing challenge is that Valkyrie and ActiveFedora's Faraday requirements conflict with the DerivativeRodeo. I put this code forward with lots of comments and the beginnings of tests to ensure that we're on the right path. Related to: - #219 - #243
This was referenced May 24, 2023
jeremyf
added a commit
that referenced
this pull request
May 24, 2023
As written, this is a draft commit. Its purpose is to share the implementation details and how we might incorporate the DerivativeRodeo into the derivative generation. This draft will break the build as it does not include adding the DerivativeRodeo as a dependency. An ongoing challenge is that Valkyrie and ActiveFedora's Faraday requirements conflict with the DerivativeRodeo. I put this code forward with lots of comments and the beginnings of tests to ensure that we're on the right path. Related to: - #219 - #243
jeremyf
added a commit
that referenced
this pull request
May 30, 2023
As written, this is a draft commit. Its purpose is to share the implementation details and how we might incorporate the DerivativeRodeo into the derivative generation. This draft will break the build as it does not include adding the DerivativeRodeo as a dependency. An ongoing challenge is that Valkyrie and ActiveFedora's Faraday requirements conflict with the DerivativeRodeo. I put this code forward with lots of comments and the beginnings of tests to ensure that we're on the right path. Related to: - #219 - #243
jeremyf
added a commit
that referenced
this pull request
May 30, 2023
As written, this is a draft commit. Its purpose is to share the implementation details and how we might incorporate the DerivativeRodeo into the derivative generation. This draft will break the build as it does not include adding the DerivativeRodeo as a dependency. An ongoing challenge is that Valkyrie and ActiveFedora's Faraday requirements conflict with the DerivativeRodeo. I put this code forward with lots of comments and the beginnings of tests to ensure that we're on the right path. Related to: - #219 - #243
jeremyf
added a commit
that referenced
this pull request
May 30, 2023
As written, this is a draft commit. Its purpose is to share the implementation details and how we might incorporate the DerivativeRodeo into the derivative generation. This draft will break the build as it does not include adding the DerivativeRodeo as a dependency. An ongoing challenge is that Valkyrie and ActiveFedora's Faraday requirements conflict with the DerivativeRodeo. I put this code forward with lots of comments and the beginnings of tests to ensure that we're on the right path. Related to: - #219 - #243
jeremyf
added a commit
that referenced
this pull request
May 30, 2023
As written, this is a draft commit. Its purpose is to share the implementation details and how we might incorporate the DerivativeRodeo into the derivative generation. This draft will break the build as it does not include adding the DerivativeRodeo as a dependency. An ongoing challenge is that Valkyrie and ActiveFedora's Faraday requirements conflict with the DerivativeRodeo. I put this code forward with lots of comments and the beginnings of tests to ensure that we're on the right path. Related to: - #219 - #243
jeremyf
added a commit
that referenced
this pull request
May 31, 2023
As written, this is a draft commit. Its purpose is to share the implementation details and how we might incorporate the DerivativeRodeo into the derivative generation. This draft will break the build as it does not include adding the DerivativeRodeo as a dependency. An ongoing challenge is that Valkyrie and ActiveFedora's Faraday requirements conflict with the DerivativeRodeo. I put this code forward with lots of comments and the beginnings of tests to ensure that we're on the right path. Related to: - #219 - #243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why as a development dependency? Because the DerivativeRodeo introduces a dependency on Faraday >= 1. And the Valkyrie and ActiveFedora versions which Hyrax 2 and 3 depend on have a Faraday dependency of < 1.
I am pushing this up so that I can begin development on the ingest aspect of the Derivative Rodeo. Also to see how this resolves in our CI setup and to see the impact, if any on downstream implementations of IIIF Print (e.g. Adventist, British Library, ATLA, PALNI/PALCI, UTK, and others).
The plan is to determine if we want to have this Faraday conflict setup or if we want to swap out something else in the underlying DerivativeRodeo.
Related to: