Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Adding derivative_rodeo as dev dependency #243

Closed
wants to merge 1 commit into from

Commits on May 24, 2023

  1. ⚙️ Adding derivative_rodeo as dev dependency

    Why as a development dependency?  Because the DerivativeRodeo introduces
    a dependency on Faraday >= 1.  And the Valkyrie and ActiveFedora
    versions which Hyrax 2 and 3 depend on have a Faraday dependency of < 1.
    
    I am pushing this up so that I can begin development on the ingest
    aspect of the Derivative Rodeo.  Also to see how this resolves in our CI
    setup and to see the impact, if any on downstream implementations of
    IIIF Print (e.g. Adventist, British Library, ATLA, PALNI/PALCI, UTK, and
    others).
    
    The plan is to determine if we want to have this Faraday conflict setup
    or if we want to swap out something else in the underlying
    DerivativeRodeo.
    
    Related to:
    
    - https://github.com/scientist-softserv/adventist-dl/issues/330
    - #219
    - #220
    jeremyf committed May 24, 2023
    Configuration menu
    Copy the full SHA
    1011411 View commit details
    Browse the repository at this point in the history