Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Ease how we determine preprocessed location #299

Closed
wants to merge 3 commits into from
Closed

🐛 Ease how we determine preprocessed location #299

wants to merge 3 commits into from

Commits on Nov 27, 2023

  1. 🐛 Ease how we determine preprocessed location 

    Prior to this commit, we assumed the ancestor must have an AARK_ID.
However that is not always the case.  Which is confounding given the
data structure of the files; however such is the way of the world.

With this commit we fallback to the file_set's internal information to
attempt to find the file in the preprocessed location.  Namely if the
FileSet had an import_url, we'll use that to derive where it probably
went in SpaceStone.

Note: sniffing out where this file exists in SpaceStone is a very
fragile process.

Closes #289

Related to:

- #289
    @jeremyf
    jeremyf committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    8997cf6 View commit details
    Browse the repository at this point in the history

  2. 🧹 Add .internal_test_app 

    Prior to this commit, when we'd push this to CI, we'd continue to
rebuild the `.internal_test_app`; this resulted in 2 hour build times.

By adding it to the repository, we explicitly say when we want to
rebuild the internal test application (e.g. by deleting it and letting a
local `bundle exec rake` rebuild it).

See the README.md for more details.
    @jeremyf
    jeremyf committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    f603571 View commit details
    Browse the repository at this point in the history

  3. 🤖 Ignore generated secrets 

    I generated this file by:

1. `brew install ggshield`
2. `ggshield secret scan path .internal_test_app --recursive`
3. `ggshield secret ignore --last-found`

First, to install the Git Guardian `ggshield`.  Then to scan the newly
committed `.internal_test_app`.  Finally ignoring the last found
secrets.
    @jeremyf
    jeremyf committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    8932157 View commit details
    Browse the repository at this point in the history