Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NamedTuple compatibility in typeguard, Codecov token for upload #230

Merged
merged 4 commits into from
Jun 7, 2021

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Jun 7, 2021

The recently released typeguard 2.12.1 does not work withNamedTuple in Python 3.6 and 3.7, so this skips all versions 2.12.*. Related: #209, #199.

The Codecov upload was broken with error message

{'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

so this adds back the Codecov token previously removed in #215 to fix this. #231 is therefore no longer needed.

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #230 (683d24a) into master (956b6b8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #230   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1727      1727           
  Branches       268       268           
=========================================
  Hits          1727      1727           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956b6b8...683d24a. Read the comment docs.

@alexander-held alexander-held changed the title fix: skip typeguard 2.12.* for NamedTuple compatibility fix: NamedTuple compatibility in typeguard, Codecov token for upload Jun 7, 2021
@alexander-held alexander-held merged commit 10571e8 into master Jun 7, 2021
@alexander-held alexander-held deleted the fix/typeguard-2-12-1 branch June 7, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant