Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create query_adjective_1.sparql #381

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

Otom-obhazi
Copy link
Contributor

for adjective

Contributor checklist


Description

Related issue

  • #ISSUE_NUMBER

Copy link

github-actions bot commented Oct 16, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

This was referenced Oct 16, 2024
@andrewtavis andrewtavis self-requested a review October 16, 2024 15:48
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a bunch of changes onto this one as I decided to fix the way that we're doing references, @Otom-obhazi :) Overall the query was good. Still some work to be done in so far as you didn't get accusative or locative, and there were other masculine and feminine forms that could have been gotten, but all and all a major improvement 👏

Will check the other one later :)

@andrewtavis andrewtavis merged commit 8556bcf into scribe-org:main Oct 16, 2024
4 checks passed
@andrewtavis
Copy link
Member

@Otom-obhazi
Copy link
Contributor Author

Check the finalized queries here, @Otom-obhazi: https://github.com/scribe-org/Scribe-Data/tree/main/src/scribe_data/language_data_extraction/Slovak/adjecives :)

okay.... i see my mistake. Thank you.

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants