Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1559 tests & signatures bugs #1182

Merged
merged 4 commits into from
Apr 1, 2024
Merged

Fix 1559 tests & signatures bugs #1182

merged 4 commits into from
Apr 1, 2024

Conversation

DreamWuGit
Copy link
Member

@DreamWuGit DreamWuGit commented Mar 28, 2024

Description

this PR targets to fix issue #1186 , contains following changes:

  1. change 1559 test to use MockWallet, which can do sign
  2. Set gas price in mock block/tx
  3. fix signature for 1559 type, normalize V and use 1559 transaction request.

Issue Link

#1186

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]


How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

  • What types of design choices did you face?
  • What decisions you have made?
  • Any valuable information that could help reviewers to think critically

@DreamWuGit
Copy link
Member Author

make ready for ci testing...

@DreamWuGit DreamWuGit marked this pull request as ready for review March 28, 2024 06:50
Copy link
Member

@noel2004 noel2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but i can not replay the mainnet tx for the regression test within a short period since the geth node is not avaliable now (disk is full)

So please do not close #1141, i would test it later

@lispc
Copy link

lispc commented Apr 1, 2024

We can ask xiaojie to add 500G disk. (not of priority)

@lispc lispc merged commit afecb0b into develop Apr 1, 2024
15 checks passed
@lispc lispc deleted the fix_1559_signature_tests branch April 1, 2024 09:06
@lispc lispc mentioned this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants