Split up PCA tests #3268
Merged
Split up PCA tests #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flying-sheep
changed the title
test_pca_transform
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3268 +/- ##
==========================================
+ Coverage 76.74% 76.95% +0.20%
==========================================
Files 109 109
Lines 12466 12466
==========================================
+ Hits 9567 9593 +26
+ Misses 2899 2873 -26
Flags with carried forward coverage won't be shown. Click here to find out more. |
flying-sheep
changed the title
test_pca_transform
meeseeksmachine
pushed a commit
to meeseeksmachine/scanpy
that referenced
this pull request
Sep 30, 2024
flying-sheep
added a commit
that referenced
this pull request
Sep 30, 2024
Co-authored-by: Philipp A <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s 3 separate unit tests in a trenchcoat. I’m only not going with
pytest.mark.parametrizesince #3263 and #3267 are making things more complicated and might cause a split anyway.The PCA code is too branched for these tests to be helpful with debugging.