-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version v3.1.2 #114
Version v3.1.2 #114
Commits on Mar 23, 2018
-
Fix gray-scale plotting of networks
Due to a copy-paste error, gray-scale plotting misbehaved. This is fixed by setting proper names on the correct vectors. Thanks to @ecklbarb for pointing this out. Signed-off-by: Claus Hunsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 730cc54 - Browse repository at this point
Copy the full SHA 730cc54View commit details
Commits on Mar 26, 2018
-
Change default plotting layout to 'igraph::layout.kamada.kawai'
When plotting networks using the default layout of the package 'ggraph' (i.e., 'igraph::layout_nicely'), we experienced segfaults in R. Therefore, we change the default layout to 'igraph::layout.kamada.kawai'. This essentially fixes #109. Thanks to @hechtlC for experiencing the problems and @bockthom for helping to find a solution. Signed-off-by: Claus Hunsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 15d8e5f - Browse repository at this point
Copy the full SHA 15d8e5fView commit details -
Remove parameter 'color.attr' from 'motifs.search.in.network'
As we always match motifs on the vertex attribute 'type', the existing parameter to the function 'motifs.search.in.network' is removed. The test suite is adapted accordingly. Additionally, the documentation is updated. Signed-off-by: Claus Hunsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f2b7851 - Browse repository at this point
Copy the full SHA f2b7851View commit details -
Change/Improve values of vertex-type and edge-type constants
The vertex and edge types as defined in the networks module ('TYPE.AUTHOR', 'TYPE.ARTIFACT', 'TYPE.EDGES.INTRA', and 'TYPE.EDGES.INTER') are defined as magic numbers (historically coming from vector indices). We refactor them to be of type 'character'. This way, we are able to actually "read" the vertex and edge attributes without any lookup from the network objects we construct. The constants are now defined as follows: TYPE.AUTHOR = "Author" TYPE.ARTIFACT = "Artifact" TYPE.EDGES.INTRA = "Unipartite" TYPE.EDGES.INTER = "Bipartite" As the motif identification works on numerics for the vertex encoding (see 'igraph::subgraph_isomorphisms', method 'vf2'), the corresponding code is adapted to transform the (now) character constants reliably back to numerics. For this, we introduce the mapping 'MOTIF.TYPE.MAPPING' and the function 'get.vertex.types.as.numeric'. As we manually translate vertex and edge types to strings for display in the plotting module, the module gets appropriate fixes and clean-ups. Here, the legend name for author vertices is not 'TYPE.AUTHOR', but "Developer". The behavior can be overwritten via setting 'PLOT.VERTEX.TYPE.AUTHOR' (and 'PLOT.VERTEX.TYPE.ARTIFACT', respectively) appropriately. This fixes #110. Thanks to @bockthom for his numerous remarks on this change. Signed-off-by: Claus Hunsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 59871b7 - Browse repository at this point
Copy the full SHA 59871b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56b1f1f - Browse repository at this point
Copy the full SHA 56b1f1fView commit details -
Enforce coding guideline on "authors"
In some places, we still use the word "developer" in our codebase, although we state in the contribution guide that we only use "author". This is fixed by replacing the occurrences properly. Thanks to @bockthom for pointing this out. Signed-off-by: Claus Hunsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 04180c4 - Browse repository at this point
Copy the full SHA 04180c4View commit details -
Fix plot layout for sample network in showcase file
Signed-off-by: Claus Hunsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e1a339d - Browse repository at this point
Copy the full SHA e1a339dView commit details -
Merge pull request #111 from clhunsen/claus-updates
Various minor and major fixes and adjustments Reviewed-by: Thomas Bock <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f07ee11 - Browse repository at this point
Copy the full SHA f07ee11View commit details
Commits on Mar 28, 2018
-
Use vectors as vertex attributes instead of lists
Don't add lists containing one element as vertex attributes any more, but add just single vector elements. If a vertex attribute can have multiple values per vertex (e.g., active ranges), then we need to wrap the vertex-attribute vector into an individual list per vertex. This has one side effect: Vertex attributes where simply are dates are not saved in POSIXct format any more, but as UNIX timestamps (similar to edge attributes). This fixes #112. In addition, all the corresponding tests are adjusted to the new behavior. Signed-off-by: Thomas Bock <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for abc0dcb - Browse repository at this point
Copy the full SHA abc0dcbView commit details
Commits on Apr 3, 2018
-
Add notice and test regarding ignored time zone
The function 'get.date.from.string' does currently not handle time zones, that is, it expects every input to be in UTC, even if there is another time-zone suffix in the input. To make the user aware of that, add a notice to this function and add an additional test which makes sure that the time-zone suffix is, indeed, ignored. Signed-off-by: Thomas Bock <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9a51877 - Browse repository at this point
Copy the full SHA 9a51877View commit details -
Configuration menu - View commit details
-
Copy full SHA for 619a5e8 - Browse repository at this point
Copy the full SHA 619a5e8View commit details
Commits on Apr 4, 2018
-
Minor fixes from review in PR #113
Just some small changes on comments. Signed-off-by: Thomas Bock <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2982374 - Browse repository at this point
Copy the full SHA 2982374View commit details
Commits on Apr 6, 2018
-
Merge pull request #113 from bockthom/thomas-updates
Fix lists of vertex attributes Reviewed-by: Claus Hunsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 003d494 - Browse repository at this point
Copy the full SHA 003d494View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03a70f2 - Browse repository at this point
Copy the full SHA 03a70f2View commit details