-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use *Properties
classes as argument types in Sprout
#970
Comments
I had a closer look at the implications of this and I think the check functions should actually be left as is, using So I think we should still make this change, but leave check functions as is. |
I think this is fine. I don't love the idea of just creating new object types to pass around, but I also come from a functional programming perspective rather than an OOP view. As long as it is clear and simple, it works for me. I'll have to review the design docs to see how this fits with the change, but 👍 for me for now |
[This only affects Sprout, not the
checks
package.]Change all argument types for properties arguments from
dict
to the approperiate*Properties
class.Starting at top-level functions, we should change to using
*Properties
classes and use them as far down in the function stack as possible.A natural point for transitioning to
dict
(so callingcompact_dict
on the properties) would be when the properties are fed to a check function or thewrite_json
function.The text was updated successfully, but these errors were encountered: