feat: ✨ add simple helper functions #962
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Luke W. Johnston <[email protected]>
martonvago
changed the title
Co-authored-by: Signe Kirk Brødbæk <[email protected]>
signekb
requested changes
Jan 14, 2025
seedcase_sprout/core/sprout_checks/check_resource_id_in_data_path.py
Outdated
Show resolved
Hide resolved
tests/core/sprout_checks/test_check_resource_id_in_data_path.py
Outdated
Show resolved
Hide resolved
tests/core/sprout_checks/test_check_resource_id_in_data_path.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Signe Kirk Brødbæk <[email protected]>
…checks-2-simple-helper-functions
signekb
reviewed
Jan 15, 2025
tests/core/sprout_checks/test_check_resource_id_in_data_path.py
Outdated
Show resolved
Hide resolved
3 tasks
Co-authored-by: Signe Kirk Brødbæk <[email protected]>
lwjohnst86
changed the title
lwjohnst86
requested changes
Jan 20, 2025
seedcase_sprout/core/sprout_checks/check_resource_id_in_data_path.py
Outdated
Show resolved
Hide resolved
seedcase_sprout/core/sprout_checks/check_resource_id_in_data_path.py
Outdated
Show resolved
Hide resolved
3 tasks
martonvago
commented
Jan 20, 2025
| @@ -3,8 +3,10 @@ | |||
| get_json_path_to_resource_field, | |||
| ) | |||
|
|
|||
| CHECKS_TYPE_ERROR_MESSAGE = "{field_value} is not of type '{field_type}'" | |||
There was a problem hiding this comment.
This could arguably go into a separate file or even be exposed by the checks package. As #978 will rework this, I'll just leave it like this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some simple helper functions that will be used when running more complex checks in Sprout.
As a rule, I tried to write simple checks in such a way that they only check a single thing. So if a function checks whether a field is blank, it won't fail if the field is missing or is of the wrong type, because there are separate checks for that. That said, it's always possible to argue that this doesn't make sense for some functions -- so feel free to argue if you think any checks should behave differently!
This PR needs an in-depth review.
Checklist
just run-all