12193 remove json blob for Answers, remove internal_name etc, and use nested forms to save Answers #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…one response set example
# Conflicts: # db/schema.rb
… on spec that was failing
…an, and editing answers works, using answers table, needs auto testing
…ing between answer and old style json for not applicable and boolean data type questions
… some meaningful answer data
… support flag about whether to include text like numeric answers
… a problem that needs to be fixed next. pause here to try changing form to use question id.
…reating "field_" internal names before id is available
…divisions with inherited question sets
…e info only calculating in question editing, and not in questionnaire loading
…as 'no' because '' != "yes"
…internal name usage to see what's going on and replace with nested attrs
…nfilteredquestion initializers
…cursion; progress logic not yet re-implemented
…ase 1 work in answers_migration branch
# Conflicts: # db/schema.rb # lib/tasks/one_time_changes.rake
# Conflicts: # Gemfile.lock # app/models/answer.rb # db/schema.rb
…roup questions must contain string 'field' to identify form fields that need to be saved as answers.
# Conflicts: # app/models/question.rb # db/schema.rb
…, and move the internal_name containing field migration earlier in migration history
…r migrations already deployed to staging and prod
# Conflicts: # db/migrate/20220330205139_ensure_internal_names_contain_field.rb # db/schema.rb And move migrations for removing internal name from questions and custom data from response sets to after all 'answers migration' db migrations.
DevneyHamilton
changed the title
DevneyHamilton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Business planning loads slowly because for over 300 questions and their corresponding answers, Madeline has to extract question and answer data from the database, associate answers with questions, assign required-or-not status to questions based on the loan type, render the question/answer heirarchy into html, and then make javascript adjustments to every question and answer in the browser. The way to reduce loading time is to load fewer questions and answers at once. Loading these questions in smaller portions requires:
Phase 1: replace a single json blob holding all 300+ answers in one database cell with a database table where each answer has its own row (engineering done, needs careful release)
Phase 2: replace an unconventional saving mechanism that can’t be adjusted with conventional Rails form saving (engineering done, needs careful release)
Phase 3 (canceled): divide the existing credit memo questionnaire such that each top-level section can be saved and loaded separately (engineering in progress). Maintain all legacy data through this change.
This PR represents phase 2 in the above phases.