Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12193 remove json blob for Answers, remove internal_name etc, and use nested forms to save Answers #968

Draft
wants to merge 87 commits into
base: develop
Choose a base branch
from
Draft

12193 remove json blob for Answers, remove internal_name etc, and use nested forms to save Answers #968

wants to merge 87 commits into from

Commits on Mar 9, 2022

  1. 12132: first pass at migration code, make_answers method working for … 

    …one response set example
    @DevneyHamilton
    DevneyHamilton committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    472b045 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2022

  1. 12132: notes on how things currently work and changes to make

    @DevneyHamilton
    DevneyHamilton committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    8d055ca View commit details
    Browse the repository at this point in the history

  2. 12132: adds answer table in schema.rb

    @DevneyHamilton
    DevneyHamilton committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    2f409ed View commit details
    Browse the repository at this point in the history

  3. 12132: make answers method on response set

    @DevneyHamilton
    DevneyHamilton committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    5a0c013 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into 12132_response_refactor 

    # Conflicts:
#	db/schema.rb
    @DevneyHamilton
    DevneyHamilton committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    a5c831a View commit details
    Browse the repository at this point in the history

  5. 12132: remove duplicate field in schema from merge, and add wait time… 

    … on spec that was failing
    @DevneyHamilton
    DevneyHamilton committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    27d45f8 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. WIP 12132: attempting specs on answers table to custom data and back … 

    …conversion
    @DevneyHamilton
    DevneyHamilton committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    92de0e3 View commit details
    Browse the repository at this point in the history

  2. 12132: saving form data to answers table, needs auto tests

    @DevneyHamilton
    DevneyHamilton committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    737a5dc View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2022

  1. 12132: adding answers and saving, reloading questionnaire for that lo… 

    …an, and editing answers works, using answers table, needs auto testing
    @DevneyHamilton
    DevneyHamilton committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    cccc5d2 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2022

  1. 12179: version with answer row for every question on a response set

    @DevneyHamilton
    DevneyHamilton committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    f779c1d View commit details
    Browse the repository at this point in the history

  2. 12179: one time changes rake task to make answers

    @DevneyHamilton
    DevneyHamilton committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    0db9d79 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. WIP failing specs on 12179

    @DevneyHamilton
    DevneyHamilton committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    f8de5b5 View commit details
    Browse the repository at this point in the history

  2. WIP 12197: more specs passing

    @DevneyHamilton
    DevneyHamilton committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    506add7 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. 12197: remove response blank specs, and fix some of the boolean handl… 

    …ing between answer and old style json for not applicable and boolean data type questions
    @DevneyHamilton
    DevneyHamilton committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    7cba41a View commit details
    Browse the repository at this point in the history

  2. 12179: fixing not applicable boolean madness

    @DevneyHamilton
    DevneyHamilton committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    7119f49 View commit details
    Browse the repository at this point in the history

  3. 12179: fix displaying linked document

    @DevneyHamilton
    DevneyHamilton committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    d2348c7 View commit details
    Browse the repository at this point in the history

  4. 12179: make validations on answer more expansive; just check there is… 

    … some meaningful answer data
    @DevneyHamilton
    DevneyHamilton committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    3442136 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. 12197: WIP enhanced data export working

    @DevneyHamilton
    DevneyHamilton committed May 2, 2022
    Configuration menu
    Copy the full SHA
    5a21afe View commit details
    Browse the repository at this point in the history

  2. 12179: cleaning up debugging from work making data exports work with … 

    …answers
    @DevneyHamilton
    DevneyHamilton committed May 2, 2022
    Configuration menu
    Copy the full SHA
    9a0e644 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. 12179: keep handling string numeric answers in data exports

    @DevneyHamilton
    DevneyHamilton committed May 4, 2022
    Configuration menu
    Copy the full SHA
    61377bf View commit details
    Browse the repository at this point in the history

  2. 12179: create shared specs between enhanced and numeric data exports,… 

    … support flag about whether to include text like numeric answers
    @DevneyHamilton
    DevneyHamilton committed May 4, 2022
    Configuration menu
    Copy the full SHA
    7b7b952 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. 12179: WIP specs breaking because internal names not unique, which is… 

    … a problem that needs to be fixed next. pause here to try changing form to use question id.
    @DevneyHamilton
    DevneyHamilton committed May 6, 2022
    Configuration menu
    Copy the full SHA
    b76367e View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. 12179: specs passing after addressing problem with question factory c… 

    …reating "field_" internal names before id is available
    @DevneyHamilton
    DevneyHamilton committed May 9, 2022
    Configuration menu
    Copy the full SHA
    ab44b97 View commit details
    Browse the repository at this point in the history

  2. 12179: clean up debug code, specs passing and manual tests passing

    @DevneyHamilton
    DevneyHamilton committed May 9, 2022
    Configuration menu
    Copy the full SHA
    c8bdab4 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. 12179: fix problem where data exports did not support exporting from … 

    …divisions with inherited question sets
    @DevneyHamilton
    DevneyHamilton committed May 10, 2022
    Configuration menu
    Copy the full SHA
    c6d7571 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. 12179: add boolean flag to filtered question serializer so inheritanc… 

    …e info only calculating in question editing, and not in questionnaire loading
    @DevneyHamilton
    DevneyHamilton committed May 11, 2022
    Configuration menu
    Copy the full SHA
    5a3a089 View commit details
    Browse the repository at this point in the history

  2. 12179: cleaning up comments etc

    @DevneyHamilton
    DevneyHamilton committed May 11, 2022
    Configuration menu
    Copy the full SHA
    01ff40c View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. 12179: fix handling of boolean answers, which were saving unanswered … 

    …as 'no' because '' != "yes"
    @DevneyHamilton
    DevneyHamilton committed May 16, 2022
    Configuration menu
    Copy the full SHA
    88e241c View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. 12193: WIP mostly can display form without breaking, need to rip out … 

    …internal name usage to see what's going on and replace with nested attrs
    @DevneyHamilton
    DevneyHamilton committed May 17, 2022
    Configuration menu
    Copy the full SHA
    18634e4 View commit details
    Browse the repository at this point in the history

  2. 12193: WIP saving with nested attrs for number and text answers

    @DevneyHamilton
    DevneyHamilton committed May 17, 2022
    Configuration menu
    Copy the full SHA
    88280a7 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. 12193: WIP sends params that look good for existing answers, doesn't … 

    …work for non-existing answers at all.
    @DevneyHamilton
    DevneyHamilton committed May 18, 2022
    Configuration menu
    Copy the full SHA
    87f1ef8 View commit details
    Browse the repository at this point in the history

  2. 12193: WIP attempting to make group logic work better with answer ins… 

    …tead of response. doesn't fix repetition problem where there is no existing answer
    @DevneyHamilton
    DevneyHamilton committed May 18, 2022
    Configuration menu
    Copy the full SHA
    5ac34a7 View commit details
    Browse the repository at this point in the history

  3. 12193: WIP fixed weird repeat thing with fields_for by making a new a… 

    …nswer object in answer is nil
    @DevneyHamilton
    DevneyHamilton committed May 18, 2022
    Configuration menu
    Copy the full SHA
    ece0edf View commit details
    Browse the repository at this point in the history

  4. 12193: WIP saving text & numeric answers and handling non-existant an… 

    …swers better
    @DevneyHamilton
    DevneyHamilton committed May 18, 2022
    Configuration menu
    Copy the full SHA
    a8afa31 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. 12193: not applicable workign in questionnaire w/out internal name

    @DevneyHamilton
    DevneyHamilton committed May 25, 2022
    Configuration menu
    Copy the full SHA
    da5a125 View commit details
    Browse the repository at this point in the history

  2. 12193: boolean qs working in form without internal_name

    @DevneyHamilton
    DevneyHamilton committed May 25, 2022
    Configuration menu
    Copy the full SHA
    e0e936c View commit details
    Browse the repository at this point in the history

  3. 12193: ratings working without internal_name

    @DevneyHamilton
    DevneyHamilton committed May 25, 2022
    Configuration menu
    Copy the full SHA
    b5affab View commit details
    Browse the repository at this point in the history

Commits on May 27, 2022

  1. 12193: WIP biz canvas saves most recent value but not displaying

    @DevneyHamilton
    DevneyHamilton committed May 27, 2022
    Configuration menu
    Copy the full SHA
    8b3d351 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. 12193: WIP biz canvas answers displaying

    @DevneyHamilton
    DevneyHamilton committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    242ca47 View commit details
    Browse the repository at this point in the history

  2. 12193: breakeven table saving & displaying

    @DevneyHamilton
    DevneyHamilton committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    6e4d8a8 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. 12193: linked document working without internal name

    @DevneyHamilton
    DevneyHamilton committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    a03261b View commit details
    Browse the repository at this point in the history

  2. 12193: remove internal name from build_node_lookup_table_for, all spe… 

    …cs passing
    @DevneyHamilton
    DevneyHamilton committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    8ca8d68 View commit details
    Browse the repository at this point in the history

  3. 12193: WIP internal name removed, all specs except progress numerator… 

    … passing
    @DevneyHamilton
    DevneyHamilton committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    af7e6f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. 12193: some minor improvements in performance

    @DevneyHamilton
    DevneyHamilton committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    a990591 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. 12193: saving ok with having added answers to loanfilteredquestions

    @DevneyHamilton
    DevneyHamilton committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    123251d View commit details
    Browse the repository at this point in the history

  2. 12193: remove response model

    @DevneyHamilton
    DevneyHamilton committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    264edd9 View commit details
    Browse the repository at this point in the history

  3. 12193: remove temporary code from migration in phase 1

    @DevneyHamilton
    DevneyHamilton committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    adb025b View commit details
    Browse the repository at this point in the history

  4. 12193: remove addl temporary code from migration

    @DevneyHamilton
    DevneyHamilton committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    404a17e View commit details
    Browse the repository at this point in the history

  5. 12193: print view of questionnaire working without response model

    @DevneyHamilton
    DevneyHamilton committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    02d33a0 View commit details
    Browse the repository at this point in the history

  6. 12193: drastically reduce db queries on questionnaire page load

    @DevneyHamilton
    DevneyHamilton committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    7d63c6a View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. 12193: add active record query trace as optional gem

    @DevneyHamilton
    DevneyHamilton committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    71c9129 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2022

  1. 12193: fix problem with a q group with no active children being a lea… 

    …f, making an invalid form item for an answer
    @DevneyHamilton
    DevneyHamilton committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    c3f209d View commit details
    Browse the repository at this point in the history

  2. 12193: add comment with key search term 'leaf' where q group treated … 

    …as leaf
    @DevneyHamilton
    DevneyHamilton committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    54bc71d View commit details
    Browse the repository at this point in the history

  3. 12193: remove response model spec

    @DevneyHamilton
    DevneyHamilton committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    7872704 View commit details
    Browse the repository at this point in the history

  4. 12193: remove custom data column from response sets table

    @DevneyHamilton
    DevneyHamilton committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    982272d View commit details
    Browse the repository at this point in the history

  5. 12193: remove custom data references in response set and answer models

    @DevneyHamilton
    DevneyHamilton committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    1524ebe View commit details
    Browse the repository at this point in the history

  6. 12193: remove addl code associated w custom data to answer migration

    @DevneyHamilton
    DevneyHamilton committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    e5431ed View commit details
    Browse the repository at this point in the history

  7. 12193: loan check specs passing

    @DevneyHamilton
    DevneyHamilton committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    d74a370 View commit details
    Browse the repository at this point in the history

  8. 12193: loan health check job specs pass

    @DevneyHamilton
    DevneyHamilton committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    36ad02c View commit details
    Browse the repository at this point in the history

  9. 12193: project duplication spec passing

    @DevneyHamilton
    DevneyHamilton committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    e391d63 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. 12193: remove very hard-to-trace **args from filteredquestion and loa… 

    …nfilteredquestion initializers
    @DevneyHamilton
    DevneyHamilton committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    5c48966 View commit details
    Browse the repository at this point in the history

  2. 12193: adding some guiding comments

    @DevneyHamilton
    DevneyHamilton committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    37f42a0 View commit details
    Browse the repository at this point in the history

  3. 12193: remove unused methods in response_set.rb

    @DevneyHamilton
    DevneyHamilton committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    f3938f3 View commit details
    Browse the repository at this point in the history

  4. 12193: WIP overhaul of lon filtered question initializer to handle re… 

    …cursion; progress logic not yet re-implemented
    @DevneyHamilton
    DevneyHamilton committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    b2b8722 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. 12193: got first progress spec passing with new approach

    @DevneyHamilton
    DevneyHamilton committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    ec373f8 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. 12193: all progress specs passing

    @DevneyHamilton
    DevneyHamilton committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    972f243 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. 12193: loan health check specs passing

    @DevneyHamilton
    DevneyHamilton committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    7cb057b View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. 12193: loan filtered q specs all passing

    @DevneyHamilton
    DevneyHamilton committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    72b8a52 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. 12193: all specs passing

    @DevneyHamilton
    DevneyHamilton committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    51521bc View commit details
    Browse the repository at this point in the history

  2. 12193: cache division depth on questions to speed up page loading

    @DevneyHamilton
    DevneyHamilton committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    89b4f25 View commit details
    Browse the repository at this point in the history

  3. 12193: add waits to reduce flapping in specs

    @DevneyHamilton
    DevneyHamilton committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    78137bd View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. 12193: breakeven table ok

    @DevneyHamilton
    DevneyHamilton committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    fdf5e01 View commit details
    Browse the repository at this point in the history

  2. 12193: fixed [no answer] display when editing

    @DevneyHamilton
    DevneyHamilton committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    5764013 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. 12197: ensure internal names unique

    @DevneyHamilton
    DevneyHamilton committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    a76c04e View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. 12193: cherrypick uniq internal name changes onto this branch from ph… 

    …ase 1 work in answers_migration branch
    @DevneyHamilton
    DevneyHamilton committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    09a1ed1 View commit details
    Browse the repository at this point in the history

  2. 12193: migration changes to schema.rb removing internal name

    @DevneyHamilton
    DevneyHamilton committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    f55e1dc View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. 12193: fix bug where marking breakeven table not applicable erases data

    @DevneyHamilton
    DevneyHamilton committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    3de0335 View commit details
    Browse the repository at this point in the history

  2. 12193: fix progress bug

    @DevneyHamilton
    DevneyHamilton committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    14db237 View commit details
    Browse the repository at this point in the history

  3. 12193: fix progress pct specs and remove more unused code from phase 1

    @DevneyHamilton
    DevneyHamilton committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    2f393d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Merge branch 'develop' into 12179_answers_migration 

    # Conflicts:
#	db/schema.rb
#	lib/tasks/one_time_changes.rake
    @DevneyHamilton
    DevneyHamilton committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    2966a21 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Merge branch '12179_answers_migration' into 12193_remove_internal_name 

    # Conflicts:
#	Gemfile.lock
#	app/models/answer.rb
#	db/schema.rb
    @DevneyHamilton
    DevneyHamilton committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    fde47ed View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. 12179: specs passing, added workaround where internal names for non-g… 

    …roup questions must contain string 'field' to identify form fields that need to be saved as answers.
    @DevneyHamilton
    DevneyHamilton committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    76b93c5 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Merge branch '12179_answers_migration' into 12193_remove_internal_name 

    # Conflicts:
#	app/models/question.rb
#	db/schema.rb
    @DevneyHamilton
    DevneyHamilton committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    e1aa80a View commit details
    Browse the repository at this point in the history

  2. 12193: remove instances of internal_name from answers_migration merge… 

    …, and move the internal_name containing field migration earlier in migration history
    @DevneyHamilton
    DevneyHamilton committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    58e158b View commit details
    Browse the repository at this point in the history

  3. 12179: greatly simplify database migrations and move them to run afte… 

    …r migrations already deployed to staging and prod
    @DevneyHamilton
    DevneyHamilton committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    99daf10 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Merge branch '12179_answers_migration' into 12193_remove_internal_name 

    # Conflicts:
#	db/migrate/20220330205139_ensure_internal_names_contain_field.rb
#	db/schema.rb

And move migrations for removing internal name from questions and custom data from response sets to after all 'answers migration' db migrations.
    @DevneyHamilton
    DevneyHamilton committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    9429564 View commit details
    Browse the repository at this point in the history

  2. 12193: specs passing after untangling merges and migrations

    @DevneyHamilton
    DevneyHamilton committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    ead4803 View commit details
    Browse the repository at this point in the history