loosten gem pin on sensu-plugin to support 1.2-2.0 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majormoses
force-pushed
the
feature/update-sensu-plugin
branch
from
dc4e91d
to
7828060
Compare
majormoses
force-pushed
the
feature/update-sensu-plugin
branch
from
7828060
to
651e0df
Compare
eheydrick
reviewed
May 4, 2017
| @@ -31,7 +31,7 @@ Gem::Specification.new do |s| | |||
| s.test_files = s.files.grep(%r{^(test|spec|features)/}) | |||
| s.version = SensuPluginsCpuChecks::Version::VER_STRING | |||
|
|
|||
| s.add_runtime_dependency 'sensu-plugin', '~> 1.2' | |||
| s.add_runtime_dependency 'sensu-plugin', ['>= 1.2', '< 2.0'] | |||
There was a problem hiding this comment.
aren't those equivalent? ~> 1.2 should cover 1.2 up to < 2.0 already.
There was a problem hiding this comment.
good call, I somehow read it has '~> 1.2.0' which is not the same as I proposed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
sensu-plugins/sensu-plugins-elasticsearch#71
General
Update Changelog following the conventions laid out on Keep A Changelog
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
Purpose
Loosen Gem deps to allow multiple versions of sensu-plugin to be installed.
Known Compatablity Issues
None