Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loosten gem pin on sensu-plugin to support 1.2-2.0 #25

Closed
wants to merge 1 commit into from
Closed

loosten gem pin on sensu-plugin to support 1.2-2.0 #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ This project adheres to [Semantic Versioning](http://semver.org/).
This CHANGELOG follows the format listed at [Keep A Changelog](http://keepachangelog.com/)

## [Unreleased]
## Changed
- loostened gemspec requirements on sensu-plugin to 1.2-2.0

## [1.1.0] - 2017-05-02
### Changed
- no real change just bumping due to deployment issue.
Expand Down
2 changes: 1 addition & 1 deletion sensu-plugins-cpu-checks.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Gem::Specification.new do |s|
s.test_files = s.files.grep(%r{^(test|spec|features)/})
s.version = SensuPluginsCpuChecks::Version::VER_STRING

s.add_runtime_dependency 'sensu-plugin', '~> 1.2'
s.add_runtime_dependency 'sensu-plugin', ['>= 1.2', '< 2.0']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't those equivalent? ~> 1.2 should cover 1.2 up to < 2.0 already.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, I somehow read it has '~> 1.2.0' which is not the same as I proposed.

s.add_runtime_dependency 'linux-kstat', '0.1.3'

s.add_development_dependency 'bundler', '~> 1.7'
Expand Down