-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kata/collections/start check point #51
Open
aatam10
wants to merge
34
commits into
serenity-dojo:kata/collections/start
Choose a base branch
from
aatam10:kata/collections/start-checkPoint
base: kata/collections/start
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Kata/collections/start check point #51
aatam10
wants to merge
34
commits into
serenity-dojo:kata/collections/start
from
aatam10:kata/collections/start-checkPoint
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault.xml, project.default.xml, diff.xml, laf.xml, jdk.table.xml, path.macros.xml, web-browsers.xml, keymap.xml, gradle.run.settings.xml, colors.scheme.xml, usageView.xml, mavenVersion.xml, debugger.xml
…roxy.settings.xml Delete colors.scheme.xml
Conflicts: mavenVersion.xml
…l, debugger.xml, path.macros.xml
…s.xml, git.xml, Default.xml, mavenVersion.xml
…e intentionSettings.xml
Kata/collections/start
wakaleo
reviewed
Sep 21, 2016
|
||
public BookingResponse checkIn(Pet pet) { | ||
if(pets.size()< MAXIMUM_PETS_CAPACITY) | ||
pets.add(pet); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always use curly brackets ("{}") with if statements, and respect the Java indentation conventions - otherwise it makes the code hard to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.