-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kata/collections/start check point #51
Open
aatam10
wants to merge
34
commits into
serenity-dojo:kata/collections/start
Choose a base branch
from
aatam10:kata/collections/start-checkPoint
base: kata/collections/start
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
6ea9e68
Replaced duplicate packag-info with a readme
wakaleo 38ab879
Replaced duplicate packag-info with a readme
wakaleo a42da69
IC-2016.2.2 <aatchoud@LIN55000200 Create IntelliLang.xml, git.xml, De…
56675f9
IC-2016.2.2 <aatchoud@LIN55000200 Overwrite local to https://github.c…
97756cb
IC-2016.2.2 <aatchoud@LIN55000200 Create find.xml
ce622bd
IC-2016.2.2 <aatchoud@LIN55000200 Overwrite local to https://github.c…
7f0af83
IC-2016.2.2 <aatchoud@LIN55000200 Update git.xml Create vcs.xml, gith…
ae65ec0
IC-2016.2.2 <aatchoud@LIN55000200 Update laf.xml Create ui.lnf.xml, p…
ae19afc
IC-2016.2.2 <aatchoud@LIN55000200 Update laf.xml Create colors.scheme…
679c494
IC-2016.2.2 <aatchoud@LIN55000200 Update laf.xml Delete colors.scheme…
6f5a253
IC-2016.2.2 <aatchoud@LIN55000200 Create editor.xml
a377c4b
IC-2016.2.2 <aatchoud@LIN55000200 Create debugger.renderers.xml
9449c84
IC-2016.2.2 <aatchoud@LIN55000200 Delete ui.lnf.xml
bb2a402
IC-2016.2.2 <aatchoud@LIN55000200 Create ui.lnf.xml
aatam10 56fbee8
IC-2016.2.2 <aatchoud@LIN55000200 Update diff.xml
aatam10 2e490e5
IC-2016.2.2 <aatchoud@LIN55000200 Update editor.xml
aatam10 adb2ef8
IC-2016.2.2 <aatchoud@LIN55000200 Update diff.xml
aatam10 c5d4b9f
Deleted Unnecessary files
aatam10 4ca9e97
Deleted un wanted folders
aatam10 dc28099
IC-2016.2.2 <aatchoud@LIN55000200 Update mavenVersion.xml
aatam10 7b89614
IC-2016.2.2 <aatchoud@LIN55000200 Merge branch 'master'
aatam10 c8d4207
IC-2016.2.2 <aatchoud@LIN55000200 Create keymap.xml, diff.xml, laf.xm…
aatam10 5277132
IC-2016.2.2 <aatchoud@LIN55000200 Create IntelliLang.xml, web-browser…
aatam10 184f1c3
IC-2016.2.2 <aatchoud@LIN55000200 Create ui.lnf.xml
aatam10 29a88d1
IC-2016.2.2 <aatchoud@LIN55000200 Create gradle.run.settings.xml
aatam10 9dce6ac
IC-2016.2.2 <aatchoud@LIN55000200 Update git.xml
aatam10 3298981
IC-2016.2.2 <aatchoud@LIN55000200 Delete ui.lnf.xml
aatam10 431e58e
adding .gitignore file
aatam10 a1ff26c
IC-2016.2.2 <aatchoud@LIN55000200 Merge branch 'master'
aatam10 e6d0b31
IC-2016.2.2 <aatchoud@LIN55000200 Create editor.codeinsight.xml
aatam10 bb81074
IC-2016.2.2 <aatchoud@LIN55000200 Update editor.codeinsight.xml Creat…
aatam10 ae005d5
IC-2016.2.2 <aatchoud@LIN55000200 Create toStringTemplates.xml
aatam10 9760701
Merge pull request #10 from serenity-dojo/kata/collections/start
aatam10 1095b50
Collection Kata checkpoint, checked-in the code done within 2 hrs.
aatam10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
<application> | ||
<component name="DebuggerSettings"> | ||
<option name="TRACING_FILTERS_ENABLED" value="true" /> | ||
<option name="FORCE_CLASSIC_VM" value="true" /> | ||
<option name="SKIP_SYNTHETIC_METHODS" value="true" /> | ||
<option name="SKIP_CLASSLOADERS" value="true" /> | ||
<option name="RUN_HOTSWAP_AFTER_COMPILE" value="RunHotswapAsk" /> | ||
<option name="COMPILE_BEFORE_HOTSWAP" value="true" /> | ||
<filter> | ||
<option name="PATTERN" value="com.sun.*" /> | ||
<option name="ENABLED" value="true" /> | ||
</filter> | ||
<filter> | ||
<option name="PATTERN" value="java.*" /> | ||
<option name="ENABLED" value="true" /> | ||
</filter> | ||
<filter> | ||
<option name="PATTERN" value="javax.*" /> | ||
<option name="ENABLED" value="true" /> | ||
</filter> | ||
<filter> | ||
<option name="PATTERN" value="org.omg.*" /> | ||
<option name="ENABLED" value="true" /> | ||
</filter> | ||
<filter> | ||
<option name="PATTERN" value="sun.*" /> | ||
<option name="ENABLED" value="true" /> | ||
</filter> | ||
<filter> | ||
<option name="PATTERN" value="jdk.internal.*" /> | ||
<option name="ENABLED" value="true" /> | ||
</filter> | ||
<filter> | ||
<option name="PATTERN" value="junit.*" /> | ||
<option name="ENABLED" value="true" /> | ||
</filter> | ||
<filter> | ||
<option name="PATTERN" value="com.intellij.rt.*" /> | ||
<option name="ENABLED" value="true" /> | ||
</filter> | ||
<filter> | ||
<option name="PATTERN" value="com.yourkit.runtime.*" /> | ||
<option name="ENABLED" value="true" /> | ||
</filter> | ||
<filter> | ||
<option name="PATTERN" value="com.springsource.loaded.*" /> | ||
<option name="ENABLED" value="true" /> | ||
</filter> | ||
<filter> | ||
<option name="PATTERN" value="org.springsource.loaded.*" /> | ||
<option name="ENABLED" value="true" /> | ||
</filter> | ||
<filter> | ||
<option name="PATTERN" value="javassist.*" /> | ||
<option name="ENABLED" value="true" /> | ||
</filter> | ||
<filter> | ||
<option name="PATTERN" value="org.apache.webbeans.*" /> | ||
<option name="ENABLED" value="true" /> | ||
</filter> | ||
<filter> | ||
<option name="PATTERN" value="com.ibm.ws.*" /> | ||
<option name="ENABLED" value="true" /> | ||
</filter> | ||
<filter> | ||
<option name="PATTERN" value="kotlin.*" /> | ||
<option name="ENABLED" value="true" /> | ||
</filter> | ||
</component> | ||
<component name="XDebuggerSettings"> | ||
<data-views /> | ||
<general /> | ||
<debuggers> | ||
<debugger id="kotlin_debugger"> | ||
<configuration> | ||
<option name="DEBUG_IS_FILTER_FOR_STDLIB_ALREADY_ADDED" value="true" /> | ||
</configuration> | ||
</debugger> | ||
</debuggers> | ||
</component> | ||
</application> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
src/main/java/serenitylabs/tutorials/vetclinic/collections/katas/BookingResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
package serenitylabs.tutorials.vetclinic.collections.katas; | ||
|
||
|
||
import serenitylabs.tutorials.vetclinic.Pet; | ||
|
||
/** | ||
* Created by aatchoud on 9/20/2016. | ||
*/ | ||
public class BookingResponse { | ||
private static boolean isConfirm = false; | ||
|
||
public BookingResponse(boolean isConfirm) { | ||
this.isConfirm = isConfirm; | ||
} | ||
|
||
public Boolean isConfirmed(){ | ||
return isConfirm; | ||
} | ||
|
||
} | ||
|
||
|
||
|
26 changes: 26 additions & 0 deletions
26
src/main/java/serenitylabs/tutorials/vetclinic/collections/katas/PetHotel.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package serenitylabs.tutorials.vetclinic.collections.katas; | ||
|
||
import serenitylabs.tutorials.vetclinic.Pet; | ||
|
||
import java.util.*; | ||
|
||
/** | ||
* Created by aatchoud on 9/20/2016. | ||
*/ | ||
public class PetHotel { | ||
|
||
private final int MAXIMUM_PETS_CAPACITY = 20; | ||
private Set<Pet> pets = new TreeSet<Pet>(Comparator.comparing(Pet::getName)); | ||
|
||
public Set<Pet> getPets() { | ||
return pets; | ||
} | ||
|
||
public BookingResponse checkIn(Pet pet) { | ||
if(pets.size()< MAXIMUM_PETS_CAPACITY) | ||
pets.add(pet); | ||
return new BookingResponse(true); | ||
} | ||
|
||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Your test code goes here. |
68 changes: 68 additions & 0 deletions
68
...java/serenitylabs/tutorials/vetclinic/collections/katas/WhenBookingPetsIntoAPetHotel.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 0 additions & 4 deletions
4
src/test/java/serenitylabs/tutorials/vetclinic/package-info.java
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always use curly brackets ("{}") with if statements, and respect the Java indentation conventions - otherwise it makes the code hard to read.