-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate log errors #108
Milestone
Comments
dcastro
added a commit
that referenced
this issue
Sep 8, 2023
dcastro
added a commit
that referenced
this issue
Sep 8, 2023
Problem: The server reports warnings whenever it finds a message with a tag like `@user`. Since this occurs very often, it ends up flooding the logs. Solution: Don't report warnings for blocks of type `user`, `usergroup` and `broadcast`.
dcastro
added a commit
that referenced
this issue
Sep 8, 2023
Problem: right now, when find an emoji block in a message, we split the message in two. This means this message: ``` Hey, let's meet at 10:30 🕐 tomorrow? ``` Will be interpreted as two separate sentences, `["Hey, let's meet at 10:30", "tomorrow?"]`, and "tomorrow" won't be taken into account. Solution: skip over emoji blocks, and collate adjacent text-like blocks. This is not parsed as a single sentence `["Hey, let's meet at 10:30 tomorrow?"]`
dcastro
added a commit
that referenced
this issue
Sep 8, 2023
Problem: The server reports warnings whenever it finds a message with a tag like `@user`. Since this occurs very often, it ends up flooding the logs. Solution: Don't report warnings for blocks of type `user`, `usergroup` and `broadcast`.
dcastro
added a commit
that referenced
this issue
Sep 8, 2023
Problem: right now, when find an emoji block in a message, we split the message in two. This means this message: ``` Hey, let's meet at 10:30 🕐 tomorrow? ``` Will be interpreted as two separate sentences, `["Hey, let's meet at 10:30", "tomorrow?"]`, and "tomorrow" won't be taken into account. Solution: skip over emoji blocks, and collate adjacent text-like blocks. This is now parsed as a single sentence `["Hey, let's meet at 10:30 tomorrow?"]`
dcastro
added a commit
that referenced
this issue
Sep 8, 2023
Problem: The server reports warnings whenever it finds a message with a tag like `@user`. Since this occurs very often, it ends up flooding the logs. Solution: Don't report warnings for blocks of type `user`, `usergroup` and `broadcast`.
dcastro
added a commit
that referenced
this issue
Sep 8, 2023
Problem: The server reports warnings whenever it finds a message with a tag like `@user`. Since this occurs very often, it ends up flooding the logs. Solution: Don't report warnings for blocks of type `user`, `usergroup` and `broadcast`.
dcastro
added a commit
that referenced
this issue
Sep 8, 2023
dcastro
added a commit
that referenced
this issue
Sep 8, 2023
7 tasks
dcastro
added a commit
that referenced
this issue
Sep 8, 2023
[#108] Handle messages with link previews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Clarification and motivation
Some errors we found in the staging logs, we need to investigate whether these are actual errors (and open tickets to fix them), or events we should ignore, or downgrade from "error" to "warning".
Unknown block types
Message deleted events
The text was updated successfully, but these errors were encountered: